Skip to content

Commit 7e04665

Browse files
committed
wifi: ath10k: fix NULL pointer dereference in ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev()
jira LE-1907 cve CVE-2023-52651 Rebuild_History Non-Buildable kernel-5.14.0-427.31.1.el9_4 commit-author Xingyuan Mo <hdthky0@gmail.com> commit ad25ee3 We should check whether the WMI_TLV_TAG_STRUCT_MGMT_TX_COMPL_EVENT tlv is present before accessing it, otherwise a null pointer deference error will occur. Fixes: dc40515 ("ath10k: handle mgmt tx completion event") Signed-off-by: Xingyuan Mo <hdthky0@gmail.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Link: https://msgid.link/20231208043433.271449-1-hdthky0@gmail.com (cherry picked from commit ad25ee3) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
1 parent 9997702 commit 7e04665

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/wireless/ath/ath10k/wmi-tlv.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -851,6 +851,10 @@ ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev(struct ath10k *ar, struct sk_buff *skb,
851851
}
852852

853853
ev = tb[WMI_TLV_TAG_STRUCT_MGMT_TX_COMPL_EVENT];
854+
if (!ev) {
855+
kfree(tb);
856+
return -EPROTO;
857+
}
854858

855859
arg->desc_id = ev->desc_id;
856860
arg->status = ev->status;

0 commit comments

Comments
 (0)