platform/x86/amd/hsmp: Ensure success even if hwmon registration fails

darcari · darcari · commit 754a14395064 · 2025-09-15T08:59:09.000-04:00
JIRA: https://issues.redhat.com/browse/RHEL-102859 commit de5cec2 Author: Suma Hegde <suma.hegde@amd.com> Date: Mon Aug 4 10:15:51 2025 +0000 platform/x86/amd/hsmp: Ensure success even if hwmon registration fails Even if hwmon registration fails, HSMP remains accessible through the device file, so the operation should return success. Signed-off-by: Suma Hegde <suma.hegde@amd.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/20250804101551.89866-1-suma.hegde@amd.com Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: David Arcari <darcari@redhat.com>
diff --git a/drivers/platform/x86/amd/hsmp/acpi.c b/drivers/platform/x86/amd/hsmp/acpi.c
@@ -504,7 +504,7 @@ static int init_acpi(struct device *dev)
 
 	dev_set_drvdata(dev, &hsmp_pdev->sock[sock_ind]);
 
-	return ret;
+	return 0;
 }
 
 static struct bin_attribute  hsmp_metric_tbl_attr = {

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ static int init_acpi(struct device *dev)`
`504`	`504`
`505`	`505`	`dev_set_drvdata(dev, &hsmp_pdev->sock[sock_ind]);`
`506`	`506`
`507`		`- return ret;`
	`507`	`+ return 0;`
`508`	`508`	`}`
`509`	`509`
`510`	`510`	`static struct bin_attribute hsmp_metric_tbl_attr = {`