mlxbf_gige: stop PHY during open() error paths

jira LE-1907
cve CVE-2024-35907
Rebuild_History Non-Buildable kernel-5.14.0-427.28.1.el9_4
commit-author David Thompson <davthompson@nvidia.com>
commit d6c30c5

The mlxbf_gige_open() routine starts the PHY as part of normal
initialization.  The mlxbf_gige_open() routine must stop the
PHY during its error paths.

Fixes: f92e186 ("Add Mellanox BlueField Gigabit Ethernet driver")
	Signed-off-by: David Thompson <davthompson@nvidia.com>
	Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
	Reviewed-by: Andrew Lunn <andrew@lunn.ch>
	Reviewed-by: Jiri Pirko <jiri@nvidia.com>
	Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit d6c30c5)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>

Author: PlaidCat

drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c

@@ -158,7 +158,7 @@ static int mlxbf_gige_open(struct net_device *netdev)
 
 	err = mlxbf_gige_tx_init(priv);
 	if (err)
-		goto free_irqs;
+		goto phy_deinit;
 	err = mlxbf_gige_rx_init(priv);
 	if (err)
 		goto tx_deinit;
@@ -186,6 +186,9 @@ static int mlxbf_gige_open(struct net_device *netdev)
 tx_deinit:
 	mlxbf_gige_tx_deinit(priv);
 
+phy_deinit:
+	phy_stop(phydev);
+
 free_irqs:
 	mlxbf_gige_free_irqs(priv);
 	return err;