SUNRPC: Fix missing release socket in rpc_sockname()

PlaidCat · PlaidCat · commit 31091ceaecec · 2024-09-12T13:46:40.000-04:00
jira LE-1907 Rebuild_History Non-Buildable kernel-5.14.0-284.30.1.el9_2 commit-author Wang ShaoBo <bobo.shaobowang@huawei.com> commit 50fa355 socket dynamically created is not released when getting an unintended address family type in rpc_sockname(), direct to out_release for calling sock_release(). Fixes: 2e738fd ("SUNRPC: Add API to acquire source address") Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> (cherry picked from commit 50fa355) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
@@ -1391,7 +1391,7 @@ static int rpc_sockname(struct net *net, struct sockaddr *sap, size_t salen,
 		break;
 	default:
 		err = -EAFNOSUPPORT;
-		goto out;
+		goto out_release;
 	}
 	if (err < 0) {
 		dprintk("RPC:       can't bind UDP socket (%d)\n", err);

Original file line number	Diff line number	Diff line change
`@@ -1391,7 +1391,7 @@ static int rpc_sockname(struct net net, struct sockaddr sap, size_t salen,`
`1391`	`1391`	`break;`
`1392`	`1392`	`default:`
`1393`	`1393`	`err = -EAFNOSUPPORT;`
`1394`		`- goto out;`
	`1394`	`+ goto out_release;`
`1395`	`1395`	`}`
`1396`	`1396`	`if (err < 0) {`
`1397`	`1397`	`dprintk("RPC: can't bind UDP socket (%d)\n", err);`