page_pool: remove WARN_ON() with OR

JIRA: https://issues.redhat.com/browse/RHEL-93737

commit 3e61103
Author: David Wei <dw@davidwei.uk>
Date:   Wed Jun 5 09:19:24 2024 -0700

    page_pool: remove WARN_ON() with OR

    Having an OR in WARN_ON() makes me sad because it's impossible to tell
    which condition is true when triggered.

    Split a WARN_ON() with an OR in page_pool_disable_direct_recycling().

    Signed-off-by: David Wei <dw@davidwei.uk>
    Reviewed-by: Mina Almasry <almasrymina@google.com>
    Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
    Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Author: ivecera

net/core/page_pool.c

@@ -1079,8 +1079,8 @@ void page_pool_disable_direct_recycling(struct page_pool *pool)
 	/* To avoid races with recycling and additional barriers make sure
 	 * pool and NAPI are unlinked when NAPI is disabled.
 	 */
-	WARN_ON(!test_bit(NAPI_STATE_SCHED, &pool->p.napi->state) ||
-		READ_ONCE(pool->p.napi->list_owner) != -1);
+	WARN_ON(!test_bit(NAPI_STATE_SCHED, &pool->p.napi->state));
+	WARN_ON(READ_ONCE(pool->p.napi->list_owner) != -1);
 
 	mutex_lock(&page_pools_lock);
 	WRITE_ONCE(pool->p.napi, NULL);