Merge pull request #17 from blocknotes/fix-some-rubocop-issues

Fix some RuboCop issues

Author: Mattia Roccoberton

.rubocop.yml

@@ -20,24 +20,6 @@ AllCops:
 Gemspec/RequiredRubyVersion:
   Enabled: false
 
-Naming/FileName:
-  Enabled: false
-
-Layout/LineLength:
-  Enabled: true
-  Max: 120
-
 RSpec/ExampleLength:
+  # default is 5
   Max: 10
-
-RSpec/MultipleExpectations:
-  Max: 12
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true

activeadmin_dynamic_fields.gemspec

@@ -14,6 +14,10 @@ Gem::Specification.new do |spec|
   spec.email         = 'mat@blocknot.es'
   spec.homepage      = 'https://github.com/blocknotes/activeadmin_dynamic_fields'
 
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = spec.homepage
+  spec.metadata['rubygems_mfa_required'] = 'true'
+
   spec.files         = Dir['{app,lib}/**/*', 'LICENSE.txt', 'Rakefile', 'README.md']
   spec.require_paths = ['lib']
 

spec/system/dialog_spec.rb

@@ -16,7 +16,7 @@
   context 'with a dialog' do
     subject(:author_link) { '.attributes_table .row-author a[data-df-dialog]' }
 
-    it 'opens the dialog' do
+    it 'opens the dialog', :aggregate_failures do
       visit "/admin/posts/#{post.id}"
 
       expect(page).to have_css(author_link)

spec/system/dynamic_fields_spec.rb

@@ -66,10 +66,10 @@ def test_change_css(target, attrs1, attrs2, options = {})
   end
 
   context 'with some dynamic fields' do
-    it 'checks the conditions and actions', retry: 2 do # rubocop:disable RSpec/ExampleLength
+    it 'checks the conditions and actions', :aggregate_failures, retry: 2 do # rubocop:disable RSpec/ExampleLength
       visit "/admin/posts/#{post.id}/edit"
 
-      expect(page).to have_css('#post_data_field_111[data-if="checked"][data-then="addClass red"][data-target="#post_data_field_111_input label"]') # rubocop:disable Layout/LineLength
+      expect(page).to have_css('#post_data_field_111[data-if="checked"][data-then="addClass red"][data-target="#post_data_field_111_input label"]')
 
       # --- if
       spec_message('check data-if condition')
@@ -173,7 +173,7 @@ def test_change_css(target, attrs1, attrs2, options = {})
   end
 
   context 'with some dynamic fields on a nested resource' do
-    it 'checks the conditions and actions' do
+    it 'checks the conditions and actions', :aggregate_failures do
       visit '/admin/authors/new'
 
       expect(page).not_to have_css('body.active_admin.red')

spec/system/inline_editing_spec.rb

@@ -16,7 +16,7 @@
   context 'with a column set for inline editing' do
     let(:editing_widget) { '.index_content .status_tag[data-field="published"][data-field-type="boolean"]' }
 
-    it 'includes the editing widget' do
+    it 'includes the editing widget', :aggregate_failures do
       visit "/admin/posts"
 
       expect(post.reload.published).to be_falsey