Merge rust-bitcoin/corepc#206: integration_test: Pause after node comes up

blaze-smith470pm · blaze-smith470pm · commit 4c5cdab0b302 · 2025-05-28T07:52:29.000+01:00
c188d911cd893d84fd03145c5c02f3c3d5928178 integration_test: Pause after node comes up (Tobin C. Harding)

Pull request description:

  We are getting intermittent test failures stating that the node is not available. `node` already includes code that hits the RPC API after the node is up so this is a little surprising. However it doesn't hurt to try waiting a little still.

  Just sleep for half a second after each node spins up and see if the intermittent failures go away.

ACKs for top commit:
  jamillambert:
    ACK c188d911cd893d84fd03145c5c02f3c3d5928178

Tree-SHA512: 65dc7d06703c4cf29922d21215b74bcb5491b67de2d45a4c0e5454a18b7a2cf52d8d82ff9c78f18caba0d9ba3eda2d201f772011d32d144e49a5f9c616965f6d
diff --git a/integration_test/src/lib.rs b/integration_test/src/lib.rs
@@ -69,7 +69,11 @@ impl NodeExt for Node {
             conf.args.push(arg);
         }
 
-        Node::with_conf(exe, &conf).expect("failed to create node")
+        let node = Node::with_conf(exe, &conf).expect("failed to create node");
+        // We are getting intermittent test fails.
+        // Just pause here to give the node time to sort itself out.
+        std::thread::sleep(std::time::Duration::from_millis(500));
+        node
     }
 
     fn fund_wallet(&self) {

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,11 @@ impl NodeExt for Node {`
`69`	`69`	`conf.args.push(arg);`
`70`	`70`	`}`
`71`	`71`
`72`		`- Node::with_conf(exe, &conf).expect("failed to create node")`
	`72`	`+ let node = Node::with_conf(exe, &conf).expect("failed to create node");`
	`73`	`+ // We are getting intermittent test fails.`
	`74`	`+ // Just pause here to give the node time to sort itself out.`
	`75`	`+ std::thread::sleep(std::time::Duration::from_millis(500));`
	`76`	`+ node`
`73`	`77`	`}`
`74`	`78`
`75`	`79`	`fn fund_wallet(&self) {`