Merge rust-bitcoin/corepc#210: Implement disconnectnode method and test

359ac383f28c579d5ed79ded0bba0a38cb765f0c Implement disconnectnode method and test (GideonBature)

Pull request description:

  Going by the conversations with tcharding for PR [#116 ](rust-bitcoin/corepc#116) on implementing one method at a time for easier review: This is the disconnectnode method which is a specific type that returns a (json null). Once this is approved, I’ll proceed with the next one.

ACKs for top commit:
  tcharding:
    ACK 359ac383f28c579d5ed79ded0bba0a38cb765f0c

Tree-SHA512: 3b16431e732e81edea1f290cf6436ae5ad0e72a591546b09e69eb47092c95ccef5e07be8908f20d32fb87a77cf623caf07eee0e96b96bc2fab7240af23e4286a

Author: blaze-smith470pm

client/src/client_sync/v17/mod.rs

@@ -73,6 +73,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();

client/src/client_sync/v17/network.rs

@@ -41,6 +41,22 @@ macro_rules! impl_client_v17__clearbanned {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `disconnectnode`
+#[macro_export]
+macro_rules! impl_client_v17__disconnectnode {
+    () => {
+        impl Client {
+            pub fn disconnect_node(&self, address: &str) -> Result<()> {
+                match self.call("disconnectnode", &[into_json(address)?]) {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `getaddednodeinfo`
 #[macro_export]
 macro_rules! impl_client_v17__getaddednodeinfo {

client/src/client_sync/v18/mod.rs

@@ -77,6 +77,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();

client/src/client_sync/v19/mod.rs

@@ -75,6 +75,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();

client/src/client_sync/v20.rs

@@ -72,6 +72,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();

client/src/client_sync/v21/mod.rs

@@ -74,6 +74,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();

client/src/client_sync/v22/mod.rs

@@ -74,6 +74,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();

client/src/client_sync/v23/mod.rs

@@ -76,6 +76,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();

client/src/client_sync/v24.rs

@@ -73,6 +73,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();

client/src/client_sync/v25.rs

@@ -73,6 +73,7 @@ crate::impl_client_v17__submitblock!();
 // == Network ==
 crate::impl_client_v17__addnode!();
 crate::impl_client_v17__clearbanned!();
+crate::impl_client_v17__disconnectnode!();
 crate::impl_client_v17__getaddednodeinfo!();
 crate::impl_client_v17__getnettotals!();
 crate::impl_client_v17__getnetworkinfo!();