Skip to content

Conversation

@Gazler
Copy link
Contributor

@Gazler Gazler commented Nov 21, 2024

Summary of changes

Previously, the child_spec/1 function referenced a non-existent run function. This would mean that a child spec such as:

{HashRing.Managed, [name: :foo]}

Would not work, instead requiring the start function to be explicitly specified:

{HashRing.Managed, [name: :foo, start: {HashRing.Managed, :new, [:foo, []]}]}

This commit uses the new/2 function instead.

Checklist

  • New functions have typespecs, changed functions were updated
  • Same for documentation, including moduledocs
  • Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit

  • Notes added to CHANGELOG file which describe changes at a high-level

There is no changelog?

Previously, the `child_spec/1` function referenced a non-existent run
function. This would mean that a child spec such as:

    {HashRing.Managed, [name: :foo]}

Would not work, instead requiring the start function to be explicitly
specified:

    {HashRing.Managed, [name: :foo, start: {HashRing.Managed, :new, [:foo, []]}]}

This commit uses the `new/2` function instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant