From 56eb419a100095fdf0db61730f94662b772805a1 Mon Sep 17 00:00:00 2001 From: Hans Schouten Date: Wed, 24 Sep 2025 11:38:06 +0200 Subject: [PATCH] fix(websocket): improve error and close handling - Use repr() when logging errors to ensure useful output even for non-string errors - Update on_close signature to accept (code, reason) for compatibility with newer websocket-client - Remove self.receiveThread.exit() since the exit method does not exist in receiveThread - Log close code and reason for easier debugging --- python_bitvavo_api/bitvavo.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/python_bitvavo_api/bitvavo.py b/python_bitvavo_api/bitvavo.py index 93b020c..adb672c 100644 --- a/python_bitvavo_api/bitvavo.py +++ b/python_bitvavo_api/bitvavo.py @@ -525,11 +525,10 @@ def on_error(self, ws, error): if 'error' in self.callbacks: self.callbacks['error'](error) else: - errorToConsole(error) + errorToConsole(repr(error)) - def on_close(self, ws): - self.receiveThread.exit() - debugToConsole('Closed Websocket.') + def on_close(self, ws, close_status_code=None, close_msg=None): + debugToConsole(f"Closed Websocket. code={close_status_code} reason={close_msg}") def checkReconnect(self): if('subscriptionTicker' in self.callbacks):