Use core type instead of string serviceType representation

Author: ynnt

pkg/apis/mysql/v1alpha1/mysqlcluster_defaults.go

@@ -56,6 +56,11 @@ func SetDefaults_MysqlCluster(c *MysqlCluster) {
 	if len(c.Spec.MinAvailable) == 0 && *c.Spec.Replicas > 1 {
 		c.Spec.MinAvailable = defaultMinAvailable
 	}
+
+	// set default service type
+	if c.Spec.ServiceSpec.ServiceType == "" {
+		c.Spec.ServiceSpec.ServiceType = corev1.ServiceTypeClusterIP
+	}
 }
 
 // SetDefaults for PodSpec

pkg/apis/mysql/v1alpha1/mysqlcluster_types.go

@@ -249,7 +249,7 @@ type VolumeSpec struct {
 type ServiceSpec struct {
 	// ServiceType defines a type for Services: ClusterIP, Loadbalancer, etc.
 	// +optional
-	ServiceType string `json:"type,omitempty"`
+	ServiceType core.ServiceType `json:"type,omitempty"`
 
 	// Additional annotations to append to MysqlCluster's services
 	// +optional

pkg/internal/mysqlcluster/defaults.go

@@ -81,7 +81,7 @@ func (cluster *MysqlCluster) SetDefaults(opt *options.Options) {
 
 	// set default service type
 	if cluster.Spec.ServiceSpec.ServiceType == "" {
-		cluster.Spec.ServiceSpec.ServiceType = "ClusterIP"
+		cluster.Spec.ServiceSpec.ServiceType = core.ServiceTypeClusterIP
 	}
 
 	// configure mysql based on:

pkg/internal/mysqlcluster/mysqlcluster_test.go

@@ -76,7 +76,7 @@ var _ = Describe("Test MySQL cluster wrapper", func() {
 		Expect(cluster.Spec.MysqlConf).To(HaveKey(Equal("innodb-log-file-size")))
 		Expect(cluster.Spec.MysqlConf).NotTo(HaveKey(Equal("max-binlog-size")))
 
-		Expect(cluster.Spec.ServiceSpec.ServiceType).To(Equal("ClusterIP"))
+		Expect(cluster.Spec.ServiceSpec.ServiceType).To(Equal(corev1.ServiceTypeClusterIP))
 	})
 
 	It("should use init MySQL container", func() {