Refactor to utility function

Author: wei-bo.chen

pkg/internal/mysqlcluster/defaults.go

@@ -19,7 +19,6 @@ package mysqlcluster
 import (
 	"fmt"
 	"math"
-	"regexp"
 
 	core "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
@@ -106,7 +105,7 @@ func (cluster *MysqlCluster) SetDefaults(opt *options.Options) {
 				maxBinlogSize = min(binlogSpaceLimit/3, 1*gb)
 			}
 
-			if matched, err := regexp.MatchString("([a-z.]+/)*percona(:.+)?", cluster.Spec.Image); err != nil && matched {
+			if cluster.IsPerconaImage() {
 				// binlog-space-limit = totalSpace / 2
 				setConfigIfNotSet(cluster.Spec.MysqlConf, "binlog-space-limit", humanizeSize(binlogSpaceLimit))
 			}

pkg/internal/mysqlcluster/mysqlcluster.go

@@ -220,11 +220,16 @@ func (c *MysqlCluster) UpdateSpec() {
 	}
 }
 
+// IsPerconaImage checks the MySQL image is percona or not
+func (c *MysqlCluster) IsPerconaImage() bool {
+	return strings.Contains(c.GetMysqlImage(), "percona")
+}
+
 // ShouldHaveInitContainerForMysql checks the MySQL version and returns true or false if the docker image supports or not init only
 func (c *MysqlCluster) ShouldHaveInitContainerForMysql() bool {
 	expectedRange := semver.MustParseRange(">=5.7.26 <8.0.0 || >=8.0.15")
 
-	return strings.Contains(c.GetMysqlImage(), "percona") && expectedRange(c.GetMySQLSemVer())
+	return c.IsPerconaImage() && expectedRange(c.GetMySQLSemVer())
 }
 
 // String returns the cluster name and namespace