policy (#168)

* outline

* policy

* ocpr

* tests

* cleanup

Author: bitfaster

BitFaster.Caching.UnitTests/Atomic/AtomicFactoryAsyncCacheTests.cs

@@ -114,7 +114,7 @@ public void WhenCacheContainsValuesTrim1RemovesColdestValue()
             this.cache.AddOrUpdate(1, 1);
             this.cache.AddOrUpdate(2, 2);
 
-            this.cache.Trim(1);
+            this.cache.Policy.Eviction.Trim(1);
 
             this.cache.TryGet(0, out var value).Should().BeFalse();
         }

BitFaster.Caching.UnitTests/Atomic/AtomicFactoryCacheTests.cs

@@ -114,7 +114,7 @@ public void WhenCacheContainsValuesTrim1RemovesColdestValue()
             this.cache.AddOrUpdate(1, 1);
             this.cache.AddOrUpdate(2, 2);
 
-            this.cache.Trim(1);
+            this.cache.Policy.Eviction.Trim(1);
 
             this.cache.TryGet(0, out var value).Should().BeFalse();
         }

BitFaster.Caching.UnitTests/BitFaster.Caching.UnitTests.csproj

@@ -11,6 +11,7 @@
     </PackageReference>
     <PackageReference Include="FluentAssertions" Version="6.7.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
+    <PackageReference Include="Moq" Version="4.18.1" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <PrivateAssets>all</PrivateAssets>

BitFaster.Caching.UnitTests/CachePolicyTests.cs

@@ -0,0 +1,26 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using FluentAssertions;
+using Moq;
+using Xunit;
+
+namespace BitFaster.Caching.UnitTests
+{
+    public class CachePolicyTests
+    {
+        [Fact]
+        public void WhenCtorFieldsAreAssigned()
+        {
+            var eviction = new Mock<IBoundedPolicy>();
+            var expire = new Mock<ITimePolicy>();
+
+            var cp = new CachePolicy(eviction.Object, expire.Object);
+
+            cp.Eviction.Should().Be(eviction.Object);
+            cp.ExpireAfterWrite.Should().Be(expire.Object);
+        }
+    }
+}

BitFaster.Caching.UnitTests/Lru/ClassicLruTests.cs

@@ -183,6 +183,13 @@ private void OnItemRemoved(object sender, ItemRemovedEventArgs<int, string> e)
             throw new NotImplementedException();
         }
 
+        [Fact]
+        public void ExpireAfterWriteIsDisabled()
+        {
+            lru.Policy.ExpireAfterWrite.Should().Be(NoneTimePolicy.Instance);
+            lru.Policy.ExpireAfterWrite.CanExpire.Should().BeFalse();
+        }
+
         [Fact]
         public void WhenKeyIsRequestedItIsCreatedAndCached()
         {

BitFaster.Caching.UnitTests/Lru/ConcurrentLruBuilderTests.cs

@@ -95,7 +95,7 @@ public void AsAsyncTestMetricsTLru()
                  .Build();
 
             lru.Should().BeOfType<ConcurrentTLru<int, int>>();
-            lru.Capacity.Should().Be(128);
+            lru.Policy.Eviction.Capacity.Should().Be(128);
         }
 
 
@@ -268,7 +268,7 @@ public void AsAsyncWithScoped()
 
             lru.Should().BeAssignableTo<IScopedAsyncCache<int, Disposable>>();
 
-            lru.Capacity.Should().Be(3);
+            lru.Policy.Eviction.Capacity.Should().Be(3);
         }
 
         // 7
@@ -282,7 +282,7 @@ public void WithScopedAsAsync()
                 .Build();
 
             lru.Should().BeAssignableTo<IScopedAsyncCache<int, Disposable>>();
-            lru.Capacity.Should().Be(3);
+            lru.Policy.Eviction.Capacity.Should().Be(3);
         }
 
         // 8

BitFaster.Caching.UnitTests/Lru/ConcurrentLruTests.cs

@@ -224,6 +224,18 @@ public void WhenRefToMetricsIsCapturedResultIsCorrect()
             m.HitRatio.Should().Be(0.5);
         }
 
+        [Fact]
+        public void CanExpireIsFalse()
+        {
+            this.lru.CanExpire.Should().BeFalse();
+        }
+
+        [Fact]
+        public void TimeToLiveIsInfinite()
+        {
+            this.lru.TimeToLive.Should().Be(NoneTimePolicy.Infinite);
+        }
+
         [Fact]
         public void WhenKeyIsRequestedItIsCreatedAndCached()
         {

BitFaster.Caching.UnitTests/Lru/ConcurrentTLruTests.cs

@@ -52,6 +52,18 @@ public void ConstructPartitionCtorReturnsCapacity()
             x.Capacity.Should().Be(3);
         }
 
+        [Fact]
+        public void CanExpireIsTrue()
+        {
+            this.lru.CanExpire.Should().BeTrue();
+        }
+
+        [Fact]
+        public void TimeToLiveIsCtorArg()
+        {
+            this.lru.TimeToLive.Should().Be(timeToLive);
+        }
+
         [Fact]
         public void WhenItemIsNotExpiredItIsNotRemoved()
         {

BitFaster.Caching.UnitTests/Lru/LruPolicyTests.cs

@@ -11,6 +11,12 @@ public class LruPolicyTests
     {
         private readonly LruPolicy<int, int> policy = new LruPolicy<int, int>();
 
+        [Fact]
+        public void TimeToLiveIsInfinite()
+        {
+            this.policy.TimeToLive.Should().Be(NoneTimePolicy.Infinite);
+        }
+
         [Fact]
         public void CreateItemInitializesKeyAndValue()
         {

BitFaster.Caching.UnitTests/Lru/TlruDateTimePolicyTests.cs

@@ -14,6 +14,12 @@ public class TLruDateTimePolicyTests
     {
         private readonly TLruDateTimePolicy<int, int> policy = new TLruDateTimePolicy<int, int>(TimeSpan.FromSeconds(10));
 
+        [Fact]
+        public void TimeToLiveShouldBeTenSecs()
+        {
+            this.policy.TimeToLive.Should().Be(TimeSpan.FromSeconds(10));
+        }
+
         [Fact]
         public void CreateItemInitializesKeyAndValue()
         {