ScopedAsyncAtomicFactory.Initializer: avoid unobserved task exception as well

Remove test in AsyncAtomicFactoryTests again

Author: advdotnet

BitFaster.Caching.UnitTests/Atomic/AsyncAtomicFactoryTests.cs

@@ -75,52 +75,6 @@ public async Task WhenValueCreateThrowsValueIsNotStored()
             (await a.GetValueAsync(1, k => Task.FromResult(3))).Should().Be(3);
         }
 
-        [Fact]
-        public async Task WhenValueCreateThrowsDoesNotCauseUnobservedTaskException()
-        {
-            bool unobservedExceptionThrown = false;
-
-            TaskScheduler.UnobservedTaskException += OnUnobservedTaskException;
-            try
-            {
-                await AsyncAtomicFactoryGetValueAsync();
-
-                GC.Collect();
-                GC.WaitForPendingFinalizers();
-            }
-            finally
-            {
-                TaskScheduler.UnobservedTaskException -= OnUnobservedTaskException;
-            }
-            unobservedExceptionThrown.Should().BeFalse();
-
-            void OnUnobservedTaskException(object sender, UnobservedTaskExceptionEventArgs e)
-            {
-                if (e.Exception?.InnerException is ArithmeticException)
-                {
-                    unobservedExceptionThrown = true;
-                }
-                else
-                {
-                    Assert.Fail(e.Exception?.ToString());
-                }
-
-                e.SetObserved();
-            }
-
-            static async Task AsyncAtomicFactoryGetValueAsync()
-            {
-                var a = new AsyncAtomicFactory<int, int>();
-                try
-                {
-                    _ = await a.GetValueAsync(12, (i) => throw new ArithmeticException());
-                }
-                catch (ArithmeticException)
-                {
-                }
-            }
-        }
-
         [Fact]
         public async Task WhenCallersRunConcurrentlyResultIsFromWinner()
         {

BitFaster.Caching/Atomic/ScopedAsyncAtomicFactory.cs

@@ -174,10 +174,9 @@ public async ValueTask<Scoped<V>> CreateScopeAsync<TFactory>(K key, TFactory val
 
                         return scope;
                     }
-                    catch (Exception ex)
+                    catch (Exception)
                     {
                         Volatile.Write(ref isTaskInitialized, false);
-                        tcs.SetException(ex);
                         throw;
                     }
                 }