Volatile read LFU drain status (#512)

bitfaster · web-flow · commit 8bfee3d85f36 · 2023-11-23T21:24:21.000-08:00
diff --git a/BitFaster.Caching/Lfu/ConcurrentLfu.cs b/BitFaster.Caching/Lfu/ConcurrentLfu.cs
@@ -514,7 +514,7 @@ IEnumerator IEnumerable.GetEnumerator()
 
         private void TryScheduleDrain()
         {
-            if (this.drainStatus.NonVolatileRead() >= DrainStatus.ProcessingToIdle)
+            if (this.drainStatus.VolatileRead() >= DrainStatus.ProcessingToIdle)
             {
                 return;
             }
@@ -832,8 +832,6 @@ private bool AdmitCandidate(K candidateKey, K victimKey)
             int victimFreq = this.cmSketch.EstimateFrequency(victimKey);
             int candidateFreq = this.cmSketch.EstimateFrequency(candidateKey);
 
-            //var (victimFreq, candidateFreq) = this.cmSketch.EstimateFrequency(victimKey, candidateKey);
-
             // TODO: random factor when candidate freq < 5
             return candidateFreq > victimFreq;
         }

Original file line number	Diff line number	Diff line change
`@@ -514,7 +514,7 @@ IEnumerator IEnumerable.GetEnumerator()`
`514`	`514`
`515`	`515`	`private void TryScheduleDrain()`
`516`	`516`	`{`
`517`		`- if (this.drainStatus.NonVolatileRead() >= DrainStatus.ProcessingToIdle)`
	`517`	`+ if (this.drainStatus.VolatileRead() >= DrainStatus.ProcessingToIdle)`
`518`	`518`	`{`
`519`	`519`	`return;`
`520`	`520`	`}`
`@@ -832,8 +832,6 @@ private bool AdmitCandidate(K candidateKey, K victimKey)`
`832`	`832`	`int victimFreq = this.cmSketch.EstimateFrequency(victimKey);`
`833`	`833`	`int candidateFreq = this.cmSketch.EstimateFrequency(candidateKey);`
`834`	`834`
`835`		`- //var (victimFreq, candidateFreq) = this.cmSketch.EstimateFrequency(victimKey, candidateKey);`
`836`		`-`
`837`	`835`	`// TODO: random factor when candidate freq < 5`
`838`	`836`	`return candidateFreq > victimFreq;`
`839`	`837`	`}`