Merge #8: Add zizmor github actions security analysis workflow

f6fd985 fix: deprecated method bitcoin::key::TweakedKeypair::to_inner, changed to to_keypair (Steve Myers)
bb105a0 ci: add zizmor github actions security analysis workflow (Steve Myers)

Pull request description:

  ### Description

  Added workflow to run zizmor github actions security analysis.

  See: https://woodruffw.github.io/zizmor/usage/#use-in-github-actions

  ### Notes to the reviewers

  Original PR: bitcoindevkit/bdk#1813

  I pinned zizmor to version 1.6.0.

  ### Changelog notice

  * ci: add zizmor github actions security analysis workflow and fix possible vulnerabilities

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

Top commit has no ACKs.

Tree-SHA512: 1476391c8ae702e19a78d4a271eb3ea17c52ff83928400d5f060c300eed652ec8f3d246371cf196c375bc18a6bd9025a468e6833d7232ebe933398b289fd2857

Author: notmandatory

.github/workflows/code_coverage.yml

@@ -2,6 +2,8 @@ on: [push, pull_request]
 
 name: Code Coverage
 
+permissions: {}
+
 jobs:
   Codecov:
     name: Code Coverage

.github/workflows/cont_integration.yml

@@ -2,6 +2,8 @@ on: [push, pull_request]
 
 name: CI
 
+permissions: {}
+
 jobs:
 
   prepare:

.github/workflows/cron-update-rust.yml

@@ -1,4 +1,7 @@
 name: Update rust version
+
+permissions: {}
+
 on:
   schedule:
     - cron: "0 0 15 * *" # At 00:00 on day-of-month 15.

.github/workflows/zizmor.yml

@@ -0,0 +1,35 @@
+name: Zizmor Actions Analysis
+
+on:
+  push:
+    branches: ["master"]
+  pull_request:
+    branches: ["**"]
+
+jobs:
+  zizmor:
+    runs-on: ubuntu-latest
+    permissions:
+      security-events: write
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - name: Rust Cache
+        uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6
+
+      - name: Install zizmor
+        run: cargo install zizmor --locked --version 1.6.0
+
+      - name: Run zizmor 🌈
+        run: zizmor --format sarif . > results.sarif
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Upload SARIF file
+        uses: github/codeql-action/upload-sarif@v3
+        with:
+          sarif_file: results.sarif
+          category: zizmor

wallet/src/wallet/signer.rs

@@ -577,7 +577,7 @@ fn sign_psbt_schnorr(
     let keypair = match leaf_hash {
         None => keypair
             .tap_tweak(secp, psbt_input.tap_merkle_root)
-            .to_inner(),
+            .to_keypair(),
         Some(_) => keypair, // no tweak for script spend
     };
 

wallet/tests/psbt.rs

@@ -214,7 +214,7 @@ fn test_psbt_multiple_internalkey_signers() {
     let message = Message::from(sighash);
 
     // add tweak. this was taken from `signer::sign_psbt_schnorr`
-    let keypair = keypair.tap_tweak(&secp, None).to_inner();
+    let keypair = keypair.tap_tweak(&secp, None).to_keypair();
     let (xonlykey, _parity) = XOnlyPublicKey::from_keypair(&keypair);
 
     // Must verify if we used the correct key to sign