Merge branch 'master' into testing-only

Author: dmgarland

.rspec

@@ -1 +1 @@
---color
+--color -fd

.ruby-version

@@ -1 +1 @@
-2.2.3
+1.9.2

bin/console

@@ -0,0 +1,6 @@
+#!/usr/bin/env ruby
+require 'bundler/setup'
+require 'bitbucket_rest_api'
+
+require 'pry'
+Pry.start

bitbucket_rest_api.gemspec

@@ -27,6 +27,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'simplecov', '~> 0.6.1'
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'bundler'
-  gem.add_development_dependency 'pry'
+  gem.add_development_dependency 'pry-debugger'
   gem.add_development_dependency 'mocha'
 end

lib/bitbucket_rest_api/configuration.rb

@@ -49,7 +49,7 @@ module Configuration
     DEFAULT_BASIC_AUTH         = nil
 
     # The endpoint used to connect to BitBucket if none is set, in the event that BitBucket is ever available on location
-    DEFAULT_ENDPOINT           = 'https://bitbucket.org/api'.freeze
+    DEFAULT_ENDPOINT           = 'https://api.bitbucket.org'.freeze
 
     # The value sent in the http header for 'User-Agent' if none is set
     DEFAULT_USER_AGENT         = "BitBucket Ruby Gem #{BitBucket::VERSION::STRING}".freeze

lib/bitbucket_rest_api/connection.rb

@@ -89,7 +89,9 @@ def connection(options = {})
       clear_cache unless options.empty?
       puts "OPTIONS:#{conn_options.inspect}" if ENV['DEBUG']
 
-      @connection ||= Faraday.new(conn_options.merge(:builder => stack(options)))
+      @connection ||= Faraday.new(conn_options.merge(:builder => stack(options))) do |faraday|
+        faraday.response :logger if ENV['DEBUG']
+      end
     end
 
   end # Connection

lib/bitbucket_rest_api/core_ext/hash.rb

@@ -6,6 +6,7 @@ def except(*items) # :nodoc:
 
   def except!(*keys) # :nodoc:
     copy = self.dup
+    # FIXME delete! is not a hash instance method
     keys.each { |key| copy.delete!(key) }
     copy
   end unless method_defined?(:except!)

lib/bitbucket_rest_api/error.rb

@@ -30,6 +30,9 @@ def initialize(message)
   invalid_options
   required_params
   unknown_value
+  bad_events
+  no_events
+  blank_value
 ].each do |error|
   require "bitbucket_rest_api/error/#{error}"
 end

lib/bitbucket_rest_api/error/bad_events.rb

@@ -0,0 +1,9 @@
+module BitBucket
+  module Error
+    class BadEvents < ClientError
+      def initialize(event)
+        super "The event: '#{event}', does not exist :("
+      end
+    end
+  end
+end

lib/bitbucket_rest_api/error/blank_value.rb

@@ -0,0 +1,9 @@
+module BitBucket
+  module Error
+    class BlankValue < ClientError
+      def initialize(required_key)
+        super "The value for: '#{required_key}', cannot be blank :("
+      end
+    end
+  end
+end