Skip to content

Commit 89226cf

Browse files
committed
Extract repeated methods into single method in api
1 parent e199cde commit 89226cf

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

lib/bitbucket_rest_api/api.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,11 @@ def method_missing(method, *args, &block) # :nodoc:
8080
end
8181
end
8282

83+
def update_and_validate_user_repo_params(user_name, repo_name)
84+
_update_user_repo_params(user_name, repo_name)
85+
_validate_user_repo_params(user, repo) unless user? && repo?
86+
end
87+
8388
def _update_user_repo_params(user_name, repo_name=nil) # :nodoc:
8489
self.user = user_name || self.user
8590
self.repo = repo_name || self.repo

lib/bitbucket_rest_api/repos/default_reviewers.rb

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ class Repos::DefaultReviewers < API
99
# bitbucket.repos.default_reviewers.list 'user-name', 'repo-name' { |reviewer| ... }
1010
#
1111
def list(user_name, repo_name, params={})
12-
_update_user_repo_params(user_name, repo_name)
13-
_validate_user_repo_params(user, repo) unless user? && repo?
12+
update_and_validate_user_repo_params(user_name, repo_name)
1413
normalize! params
1514

1615
response = get_request("/2.0/repositories/#{user_name}/#{repo_name}/default-reviewers", params)
@@ -26,8 +25,7 @@ def list(user_name, repo_name, params={})
2625
# bitbucket.repos.default_reviewers.get 'user-name', 'repo-name', 'reviewer-username'
2726
#
2827
def get(user_name, repo_name, reviewer_username, params={})
29-
_update_user_repo_params(user_name, repo_name)
30-
_validate_user_repo_params(user, repo) unless user? && repo?
28+
update_and_validate_user_repo_params(user_name, repo_name)
3129
normalize! params
3230

3331
get_request("/2.0/repositories/#{user_name}/#{repo_name}/default-reviewers/#{reviewer_username}", params)
@@ -40,8 +38,7 @@ def get(user_name, repo_name, reviewer_username, params={})
4038
# bitbucket.repos.default_reviewers.add 'user-name', 'repo-name', 'reviewer-username'
4139
#
4240
def add(user_name, repo_name, reviewer_username, params={})
43-
_update_user_repo_params(user_name, repo_name)
44-
_validate_user_repo_params(user, repo) unless user? && repo?
41+
update_and_validate_user_repo_params(user_name, repo_name)
4542
normalize! params
4643

4744
put_request("/2.0/repositories/#{user_name}/#{repo_name}/default-reviewers/#{reviewer_username}", params)
@@ -54,10 +51,8 @@ def add(user_name, repo_name, reviewer_username, params={})
5451
# bitbucket.repos.default_reviewers.remove 'user-name', 'repo-name', 'reviewer-username'
5552
#
5653
def remove(user_name, repo_name, reviewer_username, params={})
57-
_update_user_repo_params(user_name, repo_name)
58-
_validate_user_repo_params(user, repo) unless user? && repo?
54+
update_and_validate_user_repo_params(user_name, repo_name)
5955
normalize! params
60-
6156
delete_request("/2.0/repositories/#{user_name}/#{repo_name}/default-reviewers/#{reviewer_username}", params)
6257
end
6358
end

0 commit comments

Comments
 (0)