build: update nx to 15.8.9 (#495)

* ci: migrate from yarn to npm
* ci: remove test with @next version workflow

Author: dianjuar

.github/actions/setup/action.yml

@@ -15,14 +15,14 @@ runs:
     - name: Use Node.js
       uses: actions/setup-node@v3
       with:
-        cache: 'yarn'
+        cache: 'npm'
         node-version: ${{ inputs.node-version }}
         # This doesn't just set the registry url, but also sets
         # the right configuration in .npmrc that reads NPM token
         # from NPM_AUTH_TOKEN environment variable.
         # It actually creates a .npmrc in a temporary folder
         # and sets the NPM_CONFIG_USERCONFIG environment variable.
         registry-url: https://registry.npmjs.org
-    - name: yarn install
+    - name: npm install
       shell: bash
-      run: yarn --frozen-lockfile --no-progress --non-interactive --prefer-offline
+      run: npm ci

.github/workflows/angular-e2e-test.yml

@@ -1,13 +1,6 @@
 name: Angular E2E Test
 
-on:
-  workflow_call:
-    inputs:
-      # Install @angular@next instead of the current one on the package.json
-      install-next-version:
-        type: boolean
-        default: false
-        required: false
+on: workflow_call
 
 jobs:
   angular-e2e-test:
@@ -23,11 +16,6 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
 
-      # Perform angular e2e with @angular@next
-      - if: inputs.install-next-version == true
-        name: install @angular@next
-        run: npx update-by-scope -t next @angular
-
       - uses: ./.github/actions/download-build
 
       - name: yarn link

.github/workflows/basic-test.yml

@@ -9,12 +9,6 @@ on:
         default: true
         required: false
 
-      # Install @nrwl@next instead of the current one on the package.json
-      install-next-version:
-        type: boolean
-        default: false
-        required: false
-
 jobs:
   lint:
     runs-on: ubuntu-latest
@@ -24,17 +18,12 @@ jobs:
           fetch-depth: 0
       - uses: ./.github/actions/setup
 
-      # Perform lint with @nrwl@next
-      - if: inputs.install-next-version == true
-        name: install @nrwl@next
-        run: npx update-by-scope -t next @nrwl
-
       - name: Lint
         run: npx nx lint --outputFile=""
 
       - if: inputs.reports == true
         name: Lint report
-        run: npx nx lint --format ./tools/sonarqube-linter-reporter.js
+        run: npx nx lint --format=./tools/sonarqube-linter-reporter.js
 
       - if: inputs.reports == true
         name: Archive lint report results
@@ -51,11 +40,6 @@ jobs:
           fetch-depth: 0
       - uses: ./.github/actions/setup
 
-      # Perform build with @nrwl@next
-      - if: inputs.install-next-version == true
-        name: install @nrwl@next
-        run: npx update-by-scope -t next @nrwl
-
       - run: npx nx build
 
       - name: Archive build result
@@ -78,11 +62,6 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
 
-      # Perform unit test with @nrwl@next
-      - if: inputs.install-next-version == true
-        name: install @nrwl@next
-        run: npx update-by-scope -t next @nrwl
-
       - run: npx nx test --code-coverage
 
       - if: matrix.node-version == 18 && inputs.reports == true

.github/workflows/e2e-test.yml

@@ -1,13 +1,6 @@
 name: E2E Test
 
-on:
-  workflow_call:
-    inputs:
-      # Install @nrwl@next instead of the current one on the package.json
-      install-next-version:
-        type: boolean
-        default: false
-        required: false
+on: workflow_call
 
 jobs:
   e2e-test:
@@ -24,9 +17,4 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
 
-      # Perform e2e with @nrwl@next
-      - if: inputs.install-next-version == true
-        name: install @nrwl@next
-        run: npx update-by-scope -t next @nrwl
-
       - run: npx nx e2e ngx-deploy-npm-e2e

.github/workflows/next-test.yml

@@ -7,6 +7,6 @@ describe('Next', () => {
   const nxPlugin = '@nrwl/next';
 
   basicSetTestForLibs(libName, nxPlugin, {
-    libGeneratorCommandOptions: '--style css',
+    libGeneratorCommandOptions: '--style css --bundler rollup',
   });
 });

e2e/ngx-deploy-npm-e2e/integration/next.spec.ts

@@ -19,7 +19,7 @@ describe('React Native', () => {
   beforeEach(() => {
     runNxCommand(`generate ${nxPlugin}:init`);
     runCommand(
-      `yarn add -D @babel/preset-react @nrwl/web@${currentNrwlVersion}`
+      `npm add -D @babel/preset-react @nrwl/web@${currentNrwlVersion}`
     );
   });
 

e2e/ngx-deploy-npm-e2e/integration/react-native.spec.ts

@@ -4,6 +4,8 @@ import { currentNrwlVersion } from './get-nrwl-current-version';
 export function installDependencies(nxPlugin: string) {
   beforeEach(() => {
     const packageToInstall = `${nxPlugin}@${currentNrwlVersion}`;
-    runCommand(`yarn add -D ${packageToInstall}`);
+
+    runCommand(`npm add -D ${packageToInstall}`);
+    runCommand(`npx nx g ${nxPlugin}:init`);
   }, 120000);
 }

e2e/ngx-deploy-npm-e2e/utils/install-deps.ts

@@ -1,11 +1,16 @@
-import { ensureNxProject, runNxCommand } from '@nrwl/nx-plugin/testing';
+import {
+  ensureNxProject,
+  runNxCommand,
+  runPackageManagerInstall,
+} from '@nrwl/nx-plugin/testing';
 
 export function initNgxDeployNPMProject() {
   // Init project
   beforeAll(() => {
     ensureNxProject('ngx-deploy-npm', 'dist/packages/ngx-deploy-npm');
 
     runNxCommand('generate ngx-deploy-npm:init');
+    runPackageManagerInstall();
   }, 120000);
 }
 

e2e/ngx-deploy-npm-e2e/utils/utils-ngx-deploy-npm.ts

@@ -1,3 +1,15 @@
 const nxPreset = require('@nrwl/jest/preset');
 
-module.exports = { ...nxPreset };
+module.exports = {
+  ...nxPreset,
+  /* TODO: Update to latest Jest snapshotFormat
+   * By default Nx has kept the older style of Jest Snapshot formats
+   * to prevent breaking of any existing tests with snapshots.
+   * It's recommend you update to the latest format.
+   * You can do this by removing snapshotFormat property
+   * and running tests with --update-snapshot flag.
+   * Example: "nx affected --targets=test --update-snapshot"
+   * More info: https://jestjs.io/docs/upgrading-to-jest29#snapshot-format
+   */
+  snapshotFormat: { escapeString: true, printBasicPrototype: true },
+};