Skip to content

Commit de482de

Browse files
committed
chore(release): 2.0.0
1 parent b89a513 commit de482de

File tree

3 files changed

+27
-3
lines changed

3 files changed

+27
-3
lines changed

CHANGELOG.md

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,31 @@
1-
# Change Log
1+
# Changelog
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
## [2.0.0](https://github.com/bigcommerce/script-loader-js/compare/v1.0.0...v2.0.0) (2019-10-03)
6+
7+
8+
### ⚠ BREAKING CHANGES
9+
10+
* **core:** Previously, when a script is loaded, we return the
11+
associated event object inside a promise object to the caller. With this
12+
change, we return an empty promise object instead. This change is
13+
necessary because we can't guarantee that scripts can be loaded in the
14+
same way across different browsers. For example, some browsers don't
15+
support `rel="preload"`, so as a fallback, we have to preload scripts
16+
using regular XHR calls. In that case, we don't have an event object to
17+
return to the caller. We could potentially mock the event object to keep
18+
the return values consistent. But considering it is not a very useful
19+
thing to return, we've decided to make a breaking change and return
20+
nothing instead.
21+
22+
### Bug Fixes
23+
24+
* **core:** CHECKOUT-4455 Provide fallback for browsers that don't support `preload` attribute ([0fc52e7](https://github.com/bigcommerce/script-loader-js/commit/0fc52e7))
25+
26+
27+
* **core:** CHECKOUT-4455 Stop resolving promise with load event ([670fd2c](https://github.com/bigcommerce/script-loader-js/commit/670fd2c))
28+
529
<a name="1.0.0"></a>
630
# [1.0.0](https://github.com/bigcommerce/script-loader-js/compare/v0.2.0...v1.0.0) (2019-09-23)
731

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@bigcommerce/script-loader",
3-
"version": "1.0.0",
3+
"version": "2.0.0",
44
"description": "A library for loading JavaScript files asynchronously",
55
"license": "MIT",
66
"main": "lib/index.js",

0 commit comments

Comments
 (0)