Fix truncation message showing file size in bytes instead of line count (#107)

* Initial plan

* Initial plan for fixing truncation message

Co-authored-by: bhauman <2624+bhauman@users.noreply.github.com>

* Fix truncation message to show line count instead of file size in bytes

Co-authored-by: bhauman <2624+bhauman@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bhauman <2624+bhauman@users.noreply.github.com>

Author: Copilot

.gitignore

@@ -65,3 +65,4 @@ NOTES.md
 
 # Log directories
 /logs/
+linux-install.sh

src/clojure_mcp/tools/unified_read_file/core.clj

@@ -116,6 +116,7 @@
    - :truncated-by - The reason for truncation (e.g., 'max-lines')
    - :size - The file size in bytes
    - :line-count - The number of lines returned
+   - :total-line-count - The total number of lines in the file (only present when truncated)
    - :offset - The line offset used
    - :max-line-length - The max line length used
    - :line-lengths-truncated? - Whether any lines were truncated in length
@@ -143,6 +144,10 @@
                                        (str (subs line 0 max-line-length) "...")
                                        line))))))
                   truncated-by-lines? (and limit (> (count lines) limit))
+                  ;; If truncated, count total lines in file for accurate message
+                  total-line-count (when truncated-by-lines?
+                                     (with-open [rdr (io/reader file)]
+                                       (count (line-seq rdr))))
                   content-lines (if truncated-by-lines? (take limit lines) lines)
                   content (str/join "\n" content-lines)]
               {:content content
@@ -151,6 +156,7 @@
                :truncated-by (when truncated-by-lines? "max-lines")
                :size size
                :line-count (count content-lines)
+               :total-line-count total-line-count
                :offset offset
                :max-line-length max-line-length
                :line-lengths-truncated? (and max-line-length

src/clojure_mcp/tools/unified_read_file/tool.clj

@@ -253,12 +253,12 @@ By default, reads up to " max-lines " lines, truncating lines longer than " max-
 (defn format-raw-file
   "Formats raw file content with markdown."
   [result max-lines]
-  (let [{:keys [content path size line-count offset truncated? line-lengths-truncated?]} result
+  (let [{:keys [content path size line-count offset truncated? line-lengths-truncated? total-line-count]} result
         file-type (last (str/split path #"\."))
         lang-hint (when file-type (str file-type))
         preamble (str "### " path "\n"
                       (when truncated?
-                        (str "File truncated (showing " line-count " of " size " lines)\n\n")))]
+                        (str "File truncated (showing " line-count " of " total-line-count " lines)\n\n")))]
     [(str preamble "```" lang-hint "\n" content "\n```")]))
 
 (defn format-text-collapsed-view

test/clojure_mcp/tools/unified_read_file/core_test.clj

@@ -63,21 +63,26 @@
       (is (= 2 (count (str/split (:content result) #"\n"))))
       (is (str/starts-with? (:content result) "Line 1"))
       (is (:truncated? result))
-      (is (= "max-lines" (:truncated-by result)))))
+      (is (= "max-lines" (:truncated-by result)))
+      (is (= 2 (:line-count result)))
+      (is (= 5 (:total-line-count result)))))
 
   (testing "Reading with offset and limit"
     (let [result (read-file-core/read-file (.getPath *test-file*) 1 2)]
       (is (map? result))
       (is (= 2 (count (str/split (:content result) #"\n"))))
       (is (str/starts-with? (:content result) "Line 2"))
-      (is (:truncated? result))))
+      (is (:truncated? result))
+      ;; total-line-count should be total lines in file, not remaining from offset
+      (is (= 5 (:total-line-count result)))))
 
   (testing "Reading with line length limit"
     (let [result (read-file-core/read-file (.getPath *large-test-file*) 0 5 :max-line-length 10)]
       (is (map? result))
       (is (= 5 (count (str/split (:content result) #"\n"))))
       (is (every? #(str/includes? % "...") (str/split (:content result) #"\n")))
-      (is (:line-lengths-truncated? result)))))
+      (is (:line-lengths-truncated? result))
+      (is (= 100 (:total-line-count result))))))
 
 (deftest read-file-error-test
   (testing "Reading non-existent file"

test/clojure_mcp/tools/unified_read_file/tool_test.clj

@@ -65,3 +65,27 @@
     (is (not (unified-read-file-tool/collapsible-clojure-file? "test.txt")))
     (is (not (unified-read-file-tool/collapsible-clojure-file? "test.md")))
     (is (not (unified-read-file-tool/collapsible-clojure-file? "test.js")))))
+
+(deftest format-raw-file-truncation-message-test
+  (testing "Truncation message shows total line count, not file size"
+    (let [result {:content "line1\nline2\nline3"
+                  :path "/test/file.txt"
+                  :size 118628  ; File size in bytes (should NOT be shown)
+                  :line-count 3  ; Lines shown
+                  :total-line-count 2000  ; Total lines in file (should be shown)
+                  :truncated? true}
+          formatted (unified-read-file-tool/format-raw-file result 2000)
+          formatted-str (first formatted)]
+      (is (re-find #"showing 3 of 2000 lines" formatted-str)
+          "Should show total line count (2000), not file size (118628)")))
+
+  (testing "Non-truncated file doesn't show truncation message"
+    (let [result {:content "line1\nline2"
+                  :path "/test/file.txt"
+                  :size 1000
+                  :line-count 2
+                  :truncated? false}
+          formatted (unified-read-file-tool/format-raw-file result 2000)
+          formatted-str (first formatted)]
+      (is (not (re-find #"truncated" formatted-str))
+          "Should not show truncation message when not truncated"))))