Fix Clone impl of bevy_proto_bsn's ReflectedValue (#202)

mmatvein · web-flow · commit 6942532b2882 · 2025-06-06T23:17:39.000Z
diff --git a/crates/bevy_proto_bsn/src/bsn_reflect.rs b/crates/bevy_proto_bsn/src/bsn_reflect.rs
@@ -207,11 +207,7 @@ impl Clone for ReflectedValue {
     fn clone(&self) -> Self {
         Self {
             type_id: self.type_id,
-            instance: self
-                .instance
-                .as_ref()
-                .reflect_clone()
-                .expect("Failed to clone instance"),
+            instance: self.instance.as_ref().to_dynamic(),
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -207,11 +207,7 @@ impl Clone for ReflectedValue {`
`207`	`207`	`fn clone(&self) -> Self {`
`208`	`208`	`Self {`
`209`	`209`	`type_id: self.type_id,`
`210`		`- instance: self`
`211`		`- .instance`
`212`		`- .as_ref()`
`213`		`- .reflect_clone()`
`214`		`- .expect("Failed to clone instance"),`
	`210`	`+ instance: self.instance.as_ref().to_dynamic(),`
`215`	`211`	`}`
`216`	`212`	`}`
`217`	`213`	`}`