Skip to content

PointerbuttonState::clear #21997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 1, 2025
+11 −6
Merged

PointerbuttonState::clear #21997

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0c0d1c6
Fixed a comment in `pointer_events` the event is named `Release`, not…
ickshonpe Dec 1, 2025
ffebdd0
Added a `clear` method to `PointerButtonState` to use in place of cle…
ickshonpe Dec 1, 2025
89fbaa1
Added a `clear` method to `PointerButtonState` to use in place of cle…
ickshonpe Dec 1, 2025
eb6fae2
Merge branch 'pointerbuttonstate-clear' of https://github.com/ickshon…
ickshonpe Dec 1, 2025
0f11656
Removed change included by accident.
ickshonpe Dec 1, 2025
d78efac
Update crates/bevy_picking/src/events.rs
ickshonpe Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions crates/bevy_picking/src/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,15 @@ pub struct PointerButtonState {
pub dragging_over: HashMap<Entity, HitData>,
}

impl PointerButtonState {
/// Clears all press and drag data tracked for this button on its pointer.
pub fn clear(&mut self) {
self.pressing.clear();
self.dragging.clear();
self.dragging_over.clear();
}
}

/// State for all pointers.
#[derive(Debug, Clone, Default, Resource)]
pub struct PointerState {
Expand Down Expand Up @@ -379,9 +388,7 @@ impl PointerState {
pub fn clear(&mut self, pointer_id: PointerId) {
for button in PointerButton::iter() {
if let Some(state) = self.pointer_buttons.get_mut(&(pointer_id, button)) {
state.pressing.clear();
state.dragging.clear();
state.dragging_over.clear();
state.clear()
}
}
}
Expand Down Expand Up @@ -699,9 +706,7 @@ pub fn pointer_events(
}

// Finally, we can clear the state of everything relating to presses or drags.
state.pressing.clear();
state.dragging.clear();
state.dragging_over.clear();
state.clear();
}
// Moved
PointerAction::Move { delta } => {
Expand Down
Loading