WIP on logger fix

Author: genail

Runtime/Scripts/BugReportUI.cs

@@ -402,7 +402,7 @@ private IEnumerator SubmitBugReportCoroutine()
                     // skip if size over 200MB
                     if (new FileInfo(_logger.LogPath).Length < 200 * 1024 * 1024)
                     {
-                        logFiles.Add(new Issue.LogFileReference { path = _logger.LogPath, removeAfterUpload = false });
+                        logFiles.Add(new Issue.LogFileReference { logger = _logger, removeAfterUpload = false });
                     }
                 }
             }

Runtime/Scripts/Issue.cs

@@ -46,6 +46,7 @@ public struct LogFileReference
         {
             public string path;
             public bool removeAfterUpload;
+            public Logger logger; // Optional: if set, use logger.ReadLogFileBytes() instead of path
         }
 
         public struct ScreenshotFileReference
@@ -381,8 +382,25 @@ private IEnumerator PostScreenshot(ScreenshotFileReference screenshot)
 
         private IEnumerator PostLogFile(LogFileReference logFile)
         {
-            if (File.Exists(logFile.path))
+            if (logFile.logger != null)
             {
+                // Use logger's safe read method to avoid sharing violations
+                Debug.Log("Reading BetaHub log file safely using Logger instance");
+                byte[] fileData = logFile.logger.ReadLogFileBytes();
+
+                if (fileData != null)
+                {
+                    string fileName = Path.GetFileName(logFile.logger.LogPath) ?? "BH_Player.log";
+                    yield return UploadStringAsFile("log_files", "log_file[file]", fileData, fileName, "text/plain");
+                }
+                else
+                {
+                    Debug.LogError("Failed to read log file data from Logger instance");
+                }
+            }
+            else if (File.Exists(logFile.path))
+            {
+                // Original file path logic
                 yield return UploadFile("log_files", "log_file[file]", logFile.path, "text/plain");
 
                 if (logFile.removeAfterUpload)
@@ -433,6 +451,37 @@ private IEnumerator UploadFile(string endpoint, string fieldName, string filePat
             }
         }
 
+        private IEnumerator UploadStringAsFile(string endpoint, string fieldName, byte[] fileData, string fileName, string contentType)
+        {
+            if (fileData == null)
+            {
+                Debug.LogError($"Cannot upload {fileName}: file data is null");
+                yield break;
+            }
+
+            WWWForm form = new WWWForm();
+            form.AddBinaryData(fieldName, fileData, fileName, contentType);
+
+            string url = $"{_betahubEndpoint}projects/{_projectId}/issues/g-{Id}/{endpoint}";
+            using (UnityWebRequest www = UnityWebRequest.Post(url, form))
+            {
+                www.SetRequestHeader("Authorization", "Bearer " + _updateIssueAuthToken);
+                www.SetRequestHeader("BetaHub-Project-ID", _projectId);
+                www.SetRequestHeader("Accept", "application/json");
+
+                yield return www.SendWebRequest();
+
+                if (www.result != UnityWebRequest.Result.Success)
+                {
+                    Debug.LogError($"Error uploading {fileName}: {www.error}");
+                }
+                else
+                {
+                    Debug.Log($"{fileName} uploaded successfully!");
+                }
+            }
+        }
+
         private IEnumerator PublishNow()
         {
             // Ensure we have valid parameters before proceeding

Runtime/Scripts/Logger.cs

@@ -124,6 +124,63 @@ public void ForceFlush()
             }
         }
 
+        /// <summary>
+        /// Safely reads the entire log file by temporarily closing the file stream.
+        /// This prevents file sharing violations when other parts of the application need to read the log.
+        /// </summary>
+        /// <returns>The complete log file content as a byte array, or null if an error occurs</returns>
+        public byte[] ReadLogFileBytes()
+        {
+            if (disposed || string.IsNullOrEmpty(_logPath))
+            {
+                Debug.LogWarning("Cannot read log file: Logger is disposed or log path is not set");
+                return null;
+            }
+
+            lock (lockObject)
+            {
+                try
+                {
+                    // First, flush any buffered data
+                    FlushBuffer();
+
+                    // Temporarily close the file streams
+                    writer?.Dispose();
+                    fileStream?.Dispose();
+                    writer = null;
+                    fileStream = null;
+
+                    // Now we can safely read the file since we've closed our handle
+                    byte[] fileData = null;
+                    if (File.Exists(_logPath))
+                    {
+                        fileData = File.ReadAllBytes(_logPath);
+                    }
+
+                    // Reopen the file streams to continue logging
+                    InitializeFileStream();
+
+                    return fileData;
+                }
+                catch (Exception e)
+                {
+                    Debug.LogError("Error reading log file: " + e.Message);
+
+                    // Ensure we reopen the file streams even if reading failed
+                    try
+                    {
+                        InitializeFileStream();
+                    }
+                    catch (Exception reopenEx)
+                    {
+                        Debug.LogError("Error reopening log file after failed read: " + reopenEx.Message);
+                    }
+
+                    return null;
+                }
+            }
+        }
+
         public void Dispose()
         {
             if (disposed) return;