fix(core): use node rect for intersection check

bcakmakoglu · bcakmakoglu · commit 0c07bd4e2ad7 · 2023-11-09T14:19:51.000+01:00
diff --git a/packages/core/src/store/actions.ts b/packages/core/src/store/actions.ts
@@ -670,7 +670,7 @@ export function useActions(
       const overlappingArea = getOverlappingArea(currNodeRect, nodeRect)
       const partiallyVisible = partially && overlappingArea > 0
 
-      return partiallyVisible || overlappingArea >= Number(nodeOrRect.width) * Number(nodeOrRect.height)
+      return partiallyVisible || overlappingArea >= Number(nodeRect.width) * Number(nodeRect.height)
     })
   }
 
@@ -684,7 +684,7 @@ export function useActions(
     const overlappingArea = getOverlappingArea(nodeRect, area)
     const partiallyVisible = partially && overlappingArea > 0
 
-    return partiallyVisible || overlappingArea >= Number(nodeOrRect.width) * Number(nodeOrRect.height)
+    return partiallyVisible || overlappingArea >= Number(nodeRect.width) * Number(nodeRect.height)
   }
 
   const panBy: Actions['panBy'] = (delta) => {

Original file line number	Diff line number	Diff line change
`@@ -670,7 +670,7 @@ export function useActions(`
`670`	`670`	`const overlappingArea = getOverlappingArea(currNodeRect, nodeRect)`
`671`	`671`	`const partiallyVisible = partially && overlappingArea > 0`
`672`	`672`
`673`		`- return partiallyVisible \|\| overlappingArea >= Number(nodeOrRect.width) * Number(nodeOrRect.height)`
	`673`	`+ return partiallyVisible \|\| overlappingArea >= Number(nodeRect.width) * Number(nodeRect.height)`
`674`	`674`	`})`
`675`	`675`	`}`
`676`	`676`
`@@ -684,7 +684,7 @@ export function useActions(`
`684`	`684`	`const overlappingArea = getOverlappingArea(nodeRect, area)`
`685`	`685`	`const partiallyVisible = partially && overlappingArea > 0`
`686`	`686`
`687`		`- return partiallyVisible \|\| overlappingArea >= Number(nodeOrRect.width) * Number(nodeOrRect.height)`
	`687`	`+ return partiallyVisible \|\| overlappingArea >= Number(nodeRect.width) * Number(nodeRect.height)`
`688`	`688`	`}`
`689`	`689`
`690`	`690`	`const panBy: Actions['panBy'] = (delta) => {`