MmpLdrpTls.cpp - prefer ternary if just return value

Dan Dees · Dan Dees · commit 182acf9d3aa6 · 2025-06-01T15:26:40.000+07:00
diff --git a/MemoryModule/MmpLdrpTls.cpp b/MemoryModule/MmpLdrpTls.cpp
@@ -141,12 +141,9 @@ static NTSTATUS NTAPI RtlFindLdrpHandleTlsData10() {
 }
 
 static NTSTATUS NTAPI RtlFindLdrpHandleTlsData() {
-	if (MmpGlobalDataPtr->NtVersions.MajorVersion >= 10) {
-		return RtlFindLdrpHandleTlsData10();
-	}
-	else {
-		return RtlFindLdrpHandleTlsDataOld();
-	}
+    	return MmpGlobalDataPtr->NtVersions.MajorVersion >= 10
+		? RtlFindLdrpHandleTlsData10()
+		: RtlFindLdrpHandleTlsDataOld();
 }
 
 static NTSTATUS NTAPI RtlFindLdrpReleaseTlsEntry() {

Original file line number	Diff line number	Diff line change
`@@ -141,12 +141,9 @@ static NTSTATUS NTAPI RtlFindLdrpHandleTlsData10() {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`static NTSTATUS NTAPI RtlFindLdrpHandleTlsData() {`
`144`		`- if (MmpGlobalDataPtr->NtVersions.MajorVersion >= 10) {`
`145`		`- return RtlFindLdrpHandleTlsData10();`
`146`		`- }`
`147`		`- else {`
`148`		`- return RtlFindLdrpHandleTlsDataOld();`
`149`		`- }`
	`144`	`+ return MmpGlobalDataPtr->NtVersions.MajorVersion >= 10`
	`145`	`+ ? RtlFindLdrpHandleTlsData10()`
	`146`	`+ : RtlFindLdrpHandleTlsDataOld();`
`150`	`147`	`}`
`151`	`148`
`152`	`149`	`static NTSTATUS NTAPI RtlFindLdrpReleaseTlsEntry() {`