Remove @io_bazel_rules_scala or replace with Label (#1696)

Removes all remaining internal usages of `@io_bazel_rules_scala` without
changing any actual logic. Part of #1482 and #1652, this is the last
change required before adding Bzlmod compatibility.

Updates `WORKSPACE` files to use `@rules_scala` and
`scala_register_toolchains()` instead of `@io_bazel_rules_scala` and
`register_toolchains("@io_bazel_rules_scala_toolchains//...:all")`.

Also adds all the scripts run in CI to `test_all.sh`, plus
`dt_patches/dt_patch_test.sh`.

Leaves `@io_bazel_rules_scala_config` as is for now, because it's a
documented public interface. It can be easily changed and documented in
a future commit if desired.

Also doesn't change the `io_bazel_rules_scala_` prefix for Maven
artifact repos. This could also be done and documented in a future
commit if desired.

---

This change enables `WORKSPACE` and Bzlmod users to import `rules_scala`
as `rules_scala`, instead of requiring `io_bazel_rules_scala` due to
internal dependencies.

i.e., `WORKSPACE` users can still use `http_archive` to import `rules_scala`
as `io_bazel_rules_scala`. Bzlmod users will be able to call
`bazel_dep(name = "rules_scala", repo_name = "io_bazel_rules_scala")`.
However, `io_bazel_rules_scala` is no longer required by `rules_scala`
itself.

Author: mbland

WORKSPACE

@@ -1,4 +1,4 @@
-workspace(name = "io_bazel_rules_scala")
+workspace(name = "rules_scala")
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 load("//scala:deps.bzl", "rules_scala_dependencies")
@@ -42,11 +42,11 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-load("@io_bazel_rules_scala//:scala_config.bzl", "scala_config")
+load("//:scala_config.bzl", "scala_config")
 
 scala_config(enable_compiler_dependency_tracking = True)
 
-load("//scala:toolchains.bzl", "scala_toolchains")
+load("//scala:toolchains.bzl", "scala_register_toolchains", "scala_toolchains")
 
 scala_toolchains(
     fetch_sources = True,
@@ -60,9 +60,10 @@ scala_toolchains(
 register_toolchains(
     "//scala:unused_dependency_checker_error_toolchain",
     "//test/proto:scalapb_toolchain",
-    "@io_bazel_rules_scala_toolchains//...:all",
 )
 
+scala_register_toolchains()
+
 # needed for the cross repo proto test
 local_repository(
     name = "proto_cross_repo_boundary",

dt_patches/compiler_sources/extensions.bzl

@@ -1,20 +1,20 @@
+load("@io_bazel_rules_scala_config//:config.bzl", "SCALA_VERSION")
 load(
-    "@io_bazel_rules_scala//scala:scala_cross_version.bzl",
+    "@rules_scala//scala:scala_cross_version.bzl",
     "default_maven_server_urls",
 )
 load(
-    "@io_bazel_rules_scala//scala:scala_maven_import_external.bzl",
+    "@rules_scala//scala:scala_maven_import_external.bzl",
     "scala_maven_import_external",
 )
 load(
-    "@io_bazel_rules_scala//third_party/repositories:scala_2_13.bzl",
+    "@rules_scala//third_party/repositories:scala_2_13.bzl",
     _scala_2_version = "scala_version",
 )
 load(
-    "@io_bazel_rules_scala//third_party/repositories:scala_3_5.bzl",
+    "@rules_scala//third_party/repositories:scala_3_5.bzl",
     _scala_3_version = "scala_version",
 )
-load("@io_bazel_rules_scala_config//:config.bzl", "SCALA_VERSION")
 
 _IS_SCALA_2 = SCALA_VERSION.startswith("2.")
 _IS_SCALA_3 = SCALA_VERSION.startswith("3.")

dt_patches/test_dt_patches/BUILD

@@ -1,8 +1,8 @@
+load("@rules_scala//scala:scala.bzl", "setup_scala_toolchain")
 load(
-    "@io_bazel_rules_scala//scala:scala.bzl",
-    "setup_scala_toolchain",
+    "@rules_scala//scala:scala_cross_version_select.bzl",
+    "select_for_scala_version",
 )
-load("@io_bazel_rules_scala//scala:scala_cross_version_select.bzl", "select_for_scala_version")
 
 SCALA_LIBS = ["@scala_library"] + select_for_scala_version(
     any_2 = ["@scala_reflect"],

dt_patches/test_dt_patches/WORKSPACE

@@ -3,11 +3,11 @@ workspace(name = "test_dt_patches")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 local_repository(
-    name = "io_bazel_rules_scala",
+    name = "rules_scala",
     path = "../..",
 )
 
-load("@io_bazel_rules_scala//scala:deps.bzl", "rules_scala_dependencies")
+load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
@@ -48,7 +48,7 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-load("@io_bazel_rules_scala//:scala_config.bzl", "scala_config")
+load("@rules_scala//:scala_config.bzl", "scala_config")
 
 scala_config(enable_compiler_dependency_tracking = True)
 
@@ -61,14 +61,17 @@ load("@compiler_sources//:extensions.bzl", "import_compiler_source_repos")
 
 import_compiler_source_repos()
 
-load("@io_bazel_rules_scala//scala:toolchains.bzl", "scala_toolchains")
+load(
+    "@rules_scala//scala:toolchains.bzl",
+    "scala_register_toolchains",
+    "scala_toolchains",
+)
 
 scala_toolchains(
     fetch_sources = True,
     validate_scala_version = False,
 )
 
-register_toolchains(
-    ":dt_scala_toolchain",
-    "@io_bazel_rules_scala_toolchains//...:all",
-)
+register_toolchains(":dt_scala_toolchain")
+
+scala_register_toolchains()

dt_patches/test_dt_patches/dummy/BUILD

@@ -1,4 +1,4 @@
-load("@io_bazel_rules_scala//scala:scala.bzl", "scala_library")
+load("@rules_scala//scala:scala.bzl", "scala_library")
 
 scala_library(
     name = "dummy",

dt_patches/test_dt_patches_user_srcjar/BUILD

@@ -1,8 +1,11 @@
 load(
-    "@io_bazel_rules_scala//scala:scala.bzl",
+    "@rules_scala//scala:scala.bzl",
     "setup_scala_toolchain",
 )
-load("@io_bazel_rules_scala//scala:scala_cross_version_select.bzl", "select_for_scala_version")
+load(
+    "@rules_scala//scala:scala_cross_version_select.bzl",
+    "select_for_scala_version",
+)
 
 SCALA_LIBS = ["@scala_library"] + select_for_scala_version(
     any_2 = ["@scala_reflect"],

dt_patches/test_dt_patches_user_srcjar/WORKSPACE

@@ -3,11 +3,11 @@ workspace(name = "test_dt_patches")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 local_repository(
-    name = "io_bazel_rules_scala",
+    name = "rules_scala",
     path = "../..",
 )
 
-load("@io_bazel_rules_scala//scala:deps.bzl", "rules_scala_dependencies")
+load("@rules_scala//scala:deps.bzl", "rules_scala_dependencies")
 
 rules_scala_dependencies()
 
@@ -48,7 +48,7 @@ load("@rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
 
 rules_proto_toolchains()
 
-load("@io_bazel_rules_scala//:scala_config.bzl", "scala_config")
+load("@rules_scala//:scala_config.bzl", "scala_config")
 
 scala_config(enable_compiler_dependency_tracking = True)
 
@@ -137,15 +137,18 @@ srcjars_by_version = {
     },
 }
 
-load("@io_bazel_rules_scala//scala:toolchains.bzl", "scala_toolchains")
+load(
+    "@rules_scala//scala:toolchains.bzl",
+    "scala_register_toolchains",
+    "scala_toolchains",
+)
 
 scala_toolchains(
     fetch_sources = True,
     scala_compiler_srcjars = srcjars_by_version,
     validate_scala_version = False,
 )
 
-register_toolchains(
-    ":dt_scala_toolchain",
-    "@io_bazel_rules_scala_toolchains//...:all",
-)
+register_toolchains(":dt_scala_toolchain")
+
+scala_register_toolchains()

dt_patches/test_dt_patches_user_srcjar/dummy/BUILD

@@ -1,4 +1,4 @@
-load("@io_bazel_rules_scala//scala:scala.bzl", "scala_library")
+load("@rules_scala//scala:scala.bzl", "scala_library")
 
 scala_library(
     name = "dummy",

examples/crossbuild/1_single/BUILD

@@ -1,4 +1,4 @@
-load("@io_bazel_rules_scala//scala:scala.bzl", "scala_binary", "scala_library", "scala_test")
+load("@rules_scala//scala:scala.bzl", "scala_binary", "scala_library", "scala_test")
 
 # Here we demonstrate the simplest case,
 # single binary, test or library for which we set a specific version or use the default one:

examples/crossbuild/2_deps/BUILD

@@ -1,4 +1,4 @@
-load("@io_bazel_rules_scala//scala:scala.bzl", "scala_binary", "scala_library")
+load("@rules_scala//scala:scala.bzl", "scala_binary", "scala_library")
 
 # Here we demonstrate how scala_version is propagated through deps.