Allow files in wheels to be installed to directories

Ahajha · Ahajha · commit f61b4cfff5ff · 2025-11-19T03:07:55.000-05:00
When specifying `data_files` in `py_wheel`, allow just the directory to be specified (with a trailing slash), in which case it will use the file's name. This avoids duplicating (potentially platform-specific) names.
diff --git a/python/private/py_wheel.bzl b/python/private/py_wheel.bzl
@@ -519,10 +519,13 @@ def _py_wheel_impl(ctx):
                     filename,
                 ),
             )
+
+        final_filename = filename + target_files[0].basename if filename.endswith("/") else filename
+
         other_inputs.extend(target_files)
         args.add(
             "--data_files",
-            filename + ";" + target_files[0].path,
+            final_filename + ";" + target_files[0].path,
         )
 
     ctx.actions.run(

Original file line number	Diff line number	Diff line change
`@@ -519,10 +519,13 @@ def _py_wheel_impl(ctx):`
`519`	`519`	`filename,`
`520`	`520`	`),`
`521`	`521`	`)`
	`522`	`+`
	`523`	`+ final_filename = filename + target_files[0].basename if filename.endswith("/") else filename`
	`524`	`+`
`522`	`525`	`other_inputs.extend(target_files)`
`523`	`526`	`args.add(`
`524`	`527`	`"--data_files",`
`525`		`- filename + ";" + target_files[0].path,`
	`528`	`+ final_filename + ";" + target_files[0].path,`
`526`	`529`	`)`
`527`	`530`
`528`	`531`	`ctx.actions.run(`