Allow files in wheels to be installed to directories

Ahajha · Ahajha · commit d5be86614376 · 2025-09-03T00:54:27.000-04:00
When specifying `data_files` in `py_wheel`, allow just the directory to be specified (with a trailing slash), in which case it will use the file's name. This avoids duplicating (potentially platform-specific) names.
diff --git a/python/private/py_wheel.bzl b/python/private/py_wheel.bzl
@@ -516,10 +516,13 @@ def _py_wheel_impl(ctx):
                     filename,
                 ),
             )
+
+        final_filename = filename + target_files[0].basename if filename.endswith("/") else filename
+
         other_inputs.extend(target_files)
         args.add(
             "--data_files",
-            filename + ";" + target_files[0].path,
+            final_filename + ";" + target_files[0].path,
         )
 
     ctx.actions.run(

Original file line number	Diff line number	Diff line change
`@@ -516,10 +516,13 @@ def _py_wheel_impl(ctx):`
`516`	`516`	`filename,`
`517`	`517`	`),`
`518`	`518`	`)`
	`519`	`+`
	`520`	`+ final_filename = filename + target_files[0].basename if filename.endswith("/") else filename`
	`521`	`+`
`519`	`522`	`other_inputs.extend(target_files)`
`520`	`523`	`args.add(`
`521`	`524`	`"--data_files",`
`522`		`- filename + ";" + target_files[0].path,`
	`525`	`+ final_filename + ";" + target_files[0].path,`
`523`	`526`	`)`
`524`	`527`
`525`	`528`	`ctx.actions.run(`