Merge pull request #47 from solanamonk/hydrate_polymorphic_children_from_parent

fix: hydrate polymorphic children from parent

Author: bashleigh

src/__tests__/polymorphic.repository.spec.ts

@@ -6,6 +6,7 @@ import { resolve } from 'path';
 import { AdvertRepository } from './repository/advert.repository';
 import { AbstractPolymorphicRepository } from '../';
 import { MerchantEntity } from './entities/merchant.entity';
+import { UserRepository } from './repository/user.repository';
 
 describe('AbstractPolymorphicRepository', () => {
   let connection: DataSource;
@@ -230,4 +231,40 @@ describe('AbstractPolymorphicRepository', () => {
       });
     });
   });
+
+  describe('Parent', () => {
+    describe('findOne', () => {
+      it('Can find parent entity with children', async () => {
+        const repository = AbstractPolymorphicRepository.createRepository(
+          connection,
+          UserRepository,
+        );
+        const advertRepository = AbstractPolymorphicRepository.createRepository(
+          connection,
+          AdvertRepository,
+        );
+
+        const user = await repository.save(new UserEntity());
+
+        const advert = await advertRepository.save(
+          advertRepository.create({
+            owner: user,
+          }),
+        );
+
+        let result = await repository.findOne({
+          where: { id: user.id },
+        });
+
+        result = await repository.hydrateOne(result);
+
+        expect(result).toBeInstanceOf(UserEntity);
+        expect(result?.adverts).toHaveLength(1);
+        expect(result?.adverts[0]).toBeInstanceOf(AdvertEntity);
+        expect(result?.adverts[0].id).toBe(advert.id);
+        expect(result?.adverts[0].entityType).toBe(UserEntity.name);
+        expect(result?.adverts[0].entityId).toBe(user.id);
+      });
+    });
+  });
 });

src/polymorphic.repository.ts

@@ -169,7 +169,7 @@ export abstract class AbstractPolymorphicRepository<
               resultEntities: PolymorphicChildInterface[],
               entities: PolymorphicChildInterface[],
             ) => entities.concat(...resultEntities),
-            results as PolymorphicChildInterface[],
+            [] as PolymorphicChildInterface[],
           )
         : results) as PolymorphicChildInterface | PolymorphicChildInterface[],
     };
@@ -193,7 +193,7 @@ export abstract class AbstractPolymorphicRepository<
         : {
             where: {
               [entityIdColumn(options)]: parent[PrimaryColumn(options)],
-              [entityTypeColumn(options)]: entityType,
+              [entityTypeColumn(options)]: parent.constructor.name,
             },
           },
     );