Add more onRenameRequest tests and cases

Author: mcecode

server/src/__tests__/analyzer.test.ts

@@ -16,7 +16,7 @@ import { Logger } from '../util/logger'
 const CURRENT_URI = 'dummy-uri.sh'
 
 // if you add a .sh file to testing/fixtures, update this value
-const FIXTURE_FILES_MATCHING_GLOB = 16
+const FIXTURE_FILES_MATCHING_GLOB = 17
 
 const defaultConfig = getDefaultConfiguration()
 

server/src/__tests__/server.test.ts

@@ -1471,14 +1471,16 @@ describe('server', () => {
     ) {
       const { connection } = await initializeServer()
 
-      return connection.onRenameRequest.mock.calls[0][0](
-        {
-          textDocument: { uri: FIXTURE_URI.RENAMING },
-          position: { line, character },
-          newName,
-        },
-        {} as any,
-        {} as any,
+      return updateSnapshotUris(
+        await connection.onRenameRequest.mock.calls[0][0](
+          {
+            textDocument: { uri: FIXTURE_URI.RENAMING },
+            position: { line, character },
+            newName,
+          },
+          {} as any,
+          {} as any,
+        ),
       )
     }
 
@@ -1498,5 +1500,82 @@ describe('server', () => {
       await expect(getRenameRequestResult(13, 0, '$')).rejects.toThrow()
       await expect(getRenameRequestResult(13, 0, 'new$name')).rejects.toThrow()
     })
+
+    it('returns all instances within file when no declaration is found', async () => {
+      // $HOME variable
+      expect(await getRenameRequestResult(29, 9)).toMatchInlineSnapshot(`
+        {
+          "changes": {
+            "file://__REPO_ROOT_FOLDER__/testing/fixtures/renaming.sh": [
+              {
+                "newText": "newName",
+                "range": {
+                  "end": {
+                    "character": 11,
+                    "line": 29,
+                  },
+                  "start": {
+                    "character": 7,
+                    "line": 29,
+                  },
+                },
+              },
+              {
+                "newText": "newName",
+                "range": {
+                  "end": {
+                    "character": 9,
+                    "line": 30,
+                  },
+                  "start": {
+                    "character": 5,
+                    "line": 30,
+                  },
+                },
+              },
+            ],
+          },
+        }
+      `)
+      // ls command
+      expect(await getRenameRequestResult(30, 0)).toMatchInlineSnapshot(`
+        {
+          "changes": {
+            "file://__REPO_ROOT_FOLDER__/testing/fixtures/renaming.sh": [
+              {
+                "newText": "newName",
+                "range": {
+                  "end": {
+                    "character": 13,
+                    "line": 12,
+                  },
+                  "start": {
+                    "character": 11,
+                    "line": 12,
+                  },
+                },
+              },
+              {
+                "newText": "newName",
+                "range": {
+                  "end": {
+                    "character": 2,
+                    "line": 30,
+                  },
+                  "start": {
+                    "character": 0,
+                    "line": 30,
+                  },
+                },
+              },
+            ],
+          },
+        }
+      `)
+    })
+
+    it.todo('returns all instances within file when declaration is local to file')
+    it.todo('returns all instances within scope when declaration is local to scope')
+    it.todo('returns all instances across linked files')
   })
 })

testing/fixtures.ts

@@ -53,6 +53,16 @@ export function updateSnapshotUris<
     }
 
     if (typeof data === 'object') {
+      if (data.changes) {
+        for (const key in data.changes) {
+          data.changes[key.replace(REPO_ROOT_FOLDER, '__REPO_ROOT_FOLDER__')] =
+            data.changes[key]
+          delete data.changes[key]
+        }
+
+        return data
+      }
+
       if (data.uri) {
         data.uri = data.uri.replace(REPO_ROOT_FOLDER, '__REPO_ROOT_FOLDER__')
       }

testing/fixtures/renaming.sh

@@ -26,3 +26,6 @@ done
 for ((i = 0; i < 10; i++)); do
 	echo "$((i * 2))"
 done
+
+echo "$HOME"
+ls "$HOME"