Add while read test and update test name

Author: mcecode

server/src/__tests__/server.test.ts

@@ -1739,42 +1739,47 @@ describe('server', () => {
     // These may fail in the future when tree-sitter-bash's parsing gets better
     // or when the rename symbol implementation is improved.
     describe('Edge or not covered cases', () => {
-      it('does not include variables inside let and arithmetic expressions', async () => {
+      it('only includes variables typed as variable_name', async () => {
         const iRanges = await getFirstChangeRanges(getRenameRequestResult(106, 4))
-        // This should be 6 if all instances are included.
+        // This should be 6 if all instances within let and arithmetic
+        // expressions are included.
         expect(iRanges.length).toBe(2)
+
+        const lineRanges = await getFirstChangeRanges(getRenameRequestResult(118, 10))
+        // This should be 2 if the declaration of `line` is included.
+        expect(lineRanges.length).toBe(1)
       })
 
       it('includes incorrect number of symbols for complex scopes and nesting', async () => {
-        const varRanges = await getFirstChangeRanges(getRenameRequestResult(118, 8))
+        const varRanges = await getFirstChangeRanges(getRenameRequestResult(124, 8))
         // This should only be 2 if `$var` from `3` is not included.
         expect(varRanges.length).toBe(3)
 
-        const localFuncRanges = await getFirstChangeRanges(getRenameRequestResult(138, 5))
+        const localFuncRanges = await getFirstChangeRanges(getRenameRequestResult(144, 5))
         // This should be 2 if the instance of `localFunc` in `callerFunc` is
         // also included.
         expect(localFuncRanges.length).toBe(1)
       })
 
       it('only takes into account subshells created with ( and )', async () => {
         const pipelinevarRanges = await getFirstChangeRanges(
-          getRenameRequestResult(144, 7),
+          getRenameRequestResult(150, 7),
         )
         // This should only be 1 if pipeline subshell scoping is recognized.
         expect(pipelinevarRanges.length).toBe(2)
       })
 
       it('does not take into account sourcing location and scope', async () => {
-        const FOOUris = await getChangeUris(getRenameRequestResult(148, 8))
+        const FOOUris = await getChangeUris(getRenameRequestResult(154, 8))
         // This should only be 1 if sourcing after a symbol does not affect it.
         expect(FOOUris.length).toBe(2)
 
-        const hello_worldUris = await getChangeUris(getRenameRequestResult(154, 6))
+        const hello_worldUris = await getChangeUris(getRenameRequestResult(160, 6))
         // This should only be 1 if sourcing inside an uncalled function does
         // not affect symbols outside of it.
         expect(hello_worldUris.length).toBe(2)
 
-        const PATH_INPUTUris = await getChangeUris(getRenameRequestResult(157, 9))
+        const PATH_INPUTUris = await getChangeUris(getRenameRequestResult(163, 9))
         // This should only be 1 if sourcing inside a subshell does not affect
         // symbols outside of it.
         expect(PATH_INPUTUris.length).toBe(2)

testing/fixtures/renaming.sh

@@ -113,6 +113,12 @@ for (( ; i < 10; i++)); do
 	echo "$((2 * i))"
 done
 
+# tree-sitter-bash's parsing limitations with while read loops
+
+while read -r line; do
+	echo "$line"
+done < somefile.txt
+
 # Complex nesting affects self-assignment handling
 
 1() {