fix: Remove extraneous quotations in object access

Author: hyperupcall

docs/getting-started-technical.md

@@ -79,7 +79,7 @@ local -n current_object="$current_object_name"
 declare -gA REPLY=()
 local key=
 for key in "${!current_object[@]}"; do
-	REPLY["$key"]="${current_object["$key"]}"
+	REPLY["$key"]="${current_object[$key]}"
 done
 ```
 

pkg/lib/traverse-get.sh

@@ -91,12 +91,12 @@ bash_object.traverse-get() {
 		bash_object.trace_loop
 
 		# If 'key' is not a member of object or index of array, error
-		if [ -z "${current_object["$key"]+x}" ]; then
+		if [ -z "${current_object[$key]+x}" ]; then
 			bash_object.util.die 'ERROR_NOT_FOUND' "Key or index '$key' (querytree index '$i') does not exist"
 			return
 		# If 'key' is a member of an object or index of array
 		else
-			local key_value="${current_object["$key"]}"
+			local key_value="${current_object[$key]}"
 
 			# If 'key_value' is a virtual object, dereference it
 			if [ "${key_value::2}" = $'\x1C\x1D' ]; then
@@ -165,7 +165,7 @@ bash_object.traverse-get() {
 								declare -gA REPLY=()
 								local key=
 								for key in "${!current_object[@]}"; do
-									REPLY["$key"]="${current_object["$key"]}"
+									REPLY["$key"]="${current_object[$key]}"
 								done
 							elif [ "$flag_as_what" = 'as-ref' ]; then
 								bash_object.util.die 'ERROR_INTERNAL' "--ref not implemented"
@@ -238,7 +238,7 @@ bash_object.traverse-get() {
 					bash_object.util.die 'ERROR_NOT_FOUND' "The passed querytree implies that '$key' accesses an object or array, but a string with a value of '$key_value' was found instead"
 					return
 				elif ((i+1 == ${#REPLIES[@]})); then
-					local value="${current_object["$key"]}"
+					local value="${current_object[$key]}"
 					if [ "$final_value_type" = object ]; then
 						bash_object.util.die 'ERROR_ARGUMENTS_INCORRECT_TYPE' "Queried for $final_value_type, but found existing string '$value'"
 						return

pkg/lib/traverse-set.sh

@@ -207,7 +207,7 @@ bash_object.traverse-set() {
 		bash_object.trace_loop
 
 		# If 'key' is not a member of object or index of array, error
-		if [ -z "${current_object["$key"]+x}" ]; then
+		if [ -z "${current_object[$key]+x}" ]; then
 			# If we are before the last element in the query, then error
 			if ((i+1 < ${#REPLIES[@]})); then
 				bash_object.util.die 'ERROR_NOT_FOUND' "Key or index '$key' (querytree index '$i') does not exist"
@@ -235,7 +235,7 @@ bash_object.traverse-set() {
 
 					for key in "${!object_to_copy_from[@]}"; do
 						# shellcheck disable=SC2034
-						global_object["$key"]="${object_to_copy_from["$key"]}"
+						global_object["$key"]="${object_to_copy_from[$key]}"
 					done
 				elif [ "$final_value_type" = array ]; then
 					bash_object.util.generate_vobject_name "$root_object_name" "$querytree_stack_string"
@@ -267,7 +267,7 @@ bash_object.traverse-set() {
 			fi
 		# If 'key' is already a member of object or index of array
 		else
-			local key_value="${current_object["$key"]}"
+			local key_value="${current_object[$key]}"
 
 			# If 'key_value' is a virtual object, dereference it
 			if [ "${key_value::2}" = $'\x1C\x1D' ]; then
@@ -383,7 +383,7 @@ bash_object.traverse-set() {
 					bash_object.util.die 'ERROR_NOT_FOUND' "The passed querytree implies that '$key' accesses an object or array, but a string with a value of '$key_value' was found instead"
 					return
 				elif ((i+1 == ${#REPLIES[@]})); then
-					local value="${current_object["$key"]}"
+					local value="${current_object[$key]}"
 					if [ "$final_value_type" = object ]; then
 						bash_object.util.die 'ERROR_ARGUMENTS_INCORRECT_TYPE' "Assigning an $final_value_type, but found existing string '$value'"
 						return

pkg/lib/util/trace.sh

@@ -9,7 +9,7 @@ bash_object.trace_loop() {
 		stdtrace.log 0 "current_object_name: '$current_object_name'"
 		stdtrace.log 0 "current_object=("
 		for debug_key in "${!current_object[@]}"; do
-			stdtrace.log 0 "  [$debug_key]='${current_object["$debug_key"]}'"
+			stdtrace.log 0 "  [$debug_key]='${current_object[$debug_key]}'"
 		done
 		stdtrace.log 0 ")"
 	fi
@@ -21,7 +21,7 @@ bash_object.trace_current_object() {
 		stdtrace.log 0 "current_object_name: '$current_object_name'"
 		stdtrace.log 0 "current_object=("
 		for debug_key in "${!current_object[@]}"; do
-			stdtrace.log 0 "  [$debug_key]='${current_object["$debug_key"]}'"
+			stdtrace.log 0 "  [$debug_key]='${current_object[$debug_key]}'"
 		done
 		stdtrace.log 0 ")"
 	fi