Merge pull request #94 from balassy/feature/update-dependencies

Feature/update dependencies

Author: balassy

package-lock.json

@@ -33,29 +33,29 @@
     "url": "git://github.com/balassy/aws-lambda-typescript.git"
   },
   "devDependencies": {
-    "@types/aws-lambda": "^8.10.0",
-    "@types/chai": "^4.0.4",
-    "@types/chance": "^1.0.0",
-    "@types/mocha": "^5.0.0",
-    "@types/node": "^10.0.7",
-    "@types/request": "^2.0.8",
-    "@types/request-promise-native": "^1.0.10",
-    "aws-sdk": "^2.312.0",
+    "@types/aws-lambda": "^8.10.13",
+    "@types/chai": "^4.1.4",
+    "@types/chance": "^1.0.1",
+    "@types/mocha": "^5.2.5",
+    "@types/node": "^10.9.4",
+    "@types/request": "^2.47.1",
+    "@types/request-promise-native": "^1.0.15",
+    "aws-sdk": "^2.315.0",
     "chai": "^4.1.2",
-    "chance": "^1.0.12",
+    "chance": "^1.0.16",
     "coveralls": "^3.0.2",
-    "mocha": "^5.0.0",
+    "mocha": "^5.2.0",
     "nyc": "^12.0.2",
     "request-promise-native": "^1.0.5",
     "rimraf": "^2.6.2",
-    "serverless-aws-documentation": "^1.0.0",
+    "serverless-aws-documentation": "^1.1.0",
     "serverless-domain-manager": "2.6.5",
-    "serverless-offline": "^3.25.6",
+    "serverless-offline": "^3.25.11",
     "serverless-plugin-typescript": "^1.1.5",
-    "serverless-stack-output": "^0.2.0",
-    "source-map-support": "^0.5.0",
-    "ts-mockito": "^2.3.0",
-    "ts-node": "^7.0.0",
-    "tslint": "^5.8.0"
+    "serverless-stack-output": "^0.2.3",
+    "source-map-support": "^0.5.9",
+    "ts-mockito": "^2.3.1",
+    "ts-node": "^7.0.1",
+    "tslint": "^5.11.0"
   }
 }

package.json

@@ -6,7 +6,7 @@ import { GetCityResult } from './cities.interfaces';
 import { CitiesService } from './cities.service';
 
 export class CitiesController {
-  public constructor(private _service: CitiesService) {
+  public constructor(private readonly _service: CitiesService) {
   }
 
   public getCity: ApiHandler = (event: ApiEvent, context: ApiContext, callback: ApiCallback): void => {

src/cities/cities.controller.ts

@@ -3,7 +3,7 @@ import { City, GetCityResult } from './cities.interfaces';
 import { CitiesRepository } from './cities.repository';
 
 export class CitiesService {
-  public constructor(private _repo: CitiesRepository, private _env: NodeJS.ProcessEnv) {
+  public constructor(private readonly _repo: CitiesRepository, private readonly _env: NodeJS.ProcessEnv) {
   }
 
   public getCity(id: number): Promise<GetCityResult> {

src/cities/cities.service.ts

@@ -68,7 +68,7 @@ describe('HealthController', () => {
           };
         }
 
-        handler(event, <ApiContext> {}, (error?: Error | null, result?: ApiResponse): void => {
+        handler(event, <ApiContext> {}, (error?: Error | null | string, result?: ApiResponse): void => {
           if (typeof result === 'undefined') {
             reject('No result was returned by the handler!');
             return;

src/health/health.controller.spec.ts

@@ -5,7 +5,7 @@ import { GetSwaggerResult } from './swagger.interfaces';
 import { SwaggerService } from './swagger.service';
 
 export class SwaggerController {
-  public constructor(private _service: SwaggerService) {
+  public constructor(private readonly _service: SwaggerService) {
   }
 
   public getSwaggerJson: ApiHandler = (event: ApiEvent, context: ApiContext, callback: ApiCallback): void => {

src/swagger/swagger.controller.ts

@@ -1,7 +1,7 @@
 import { APIGateway, AWSError } from 'aws-sdk';
 
 export class SwaggerRepository {
-  public constructor(private _apigw: APIGateway) {
+  public constructor(private readonly _apigw: APIGateway) {
   }
 
   public getRestApiId(stageName: string, apiName: string): Promise<string | undefined> {

src/swagger/swagger.repository.ts

@@ -5,7 +5,7 @@ import { GetSwaggerResult } from './swagger.interfaces';
 import { SwaggerRepository } from './swagger.repository';
 
 export class SwaggerService {
-  public constructor(private _repo: SwaggerRepository, private _env: NodeJS.ProcessEnv) {
+  public constructor(private readonly _repo: SwaggerRepository, private readonly _env: NodeJS.ProcessEnv) {
   }
 
   public getSwaggerDescription(): Promise<GetSwaggerResult> {

src/swagger/swagger.service.ts

@@ -13,7 +13,7 @@ export const callSuccess: SuccessCaller = <T>(handler: ApiHandler, pathParameter
       event.pathParameters = pathParameters;
     }
 
-    handler(event, <ApiContext> {}, (error?: Error | null, result?: ApiResponse): void => {
+    handler(event, <ApiContext> {}, (error?: Error | null | string, result?: ApiResponse): void => {
       if (typeof result === 'undefined') {
         reject('No result was returned by the handler!');
         return;
@@ -35,7 +35,7 @@ export const callFailure: FailureCaller = (handler: ApiHandler, pathParameters?:
       event.pathParameters = pathParameters;
     }
 
-    handler(event, <ApiContext> {}, (error?: Error | null, result?: ApiResponse): void => {
+    handler(event, <ApiContext> {}, (error?: Error | null | string, result?: ApiResponse): void => {
       if (typeof result === 'undefined') {
         reject('No result was returned by the handler!');
         return;

test/index.ts

@@ -1,11 +1,14 @@
 {
   "extends": "tslint:all",
   "rules": {
+    "await-promise": [true, "RequestPromise"],
     "completed-docs": false,
+    "file-name-casing": [true, "kebab-case"],
     "interface-name": [true, "never-prefix"],
     "linebreak-style": false,
     "max-line-length": [true, 300],
     "newline-before-return": false,
+    "newline-per-chained-call": false,
     "no-angle-bracket-type-assertion": false,
     "no-implicit-dependencies": [true, "dev"],
     "no-inferrable-types": false,