Skip to content

Conversation

@crazyhappygame
Copy link
Contributor

@crazyhappygame crazyhappygame commented Nov 30, 2025

Describe your changes

compilatin fails after enablaing ifndef AX_CORE_PROFILE

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@crazyhappygame
Copy link
Contributor Author

it looks like flakyh unit test. https://github.com/axmolengine/axmol/actions/runs/19804252495/job/56735998776?pr=2910
closing and reopen to trigger actions

@crazyhappygame
Copy link
Contributor Author

crazyhappygame commented Dec 1, 2025

https://github.com/axmolengine/axmol/actions/runs/19804252495/job/56735998776?pr=2910

/Users/runner/work/axmol/axmol/tests/unit-tests/Source/core/base/MapTests.cpp:194: ERROR: CHECK( different > mapForRandom.size() * 3 / 4 ) is NOT correct!
Can't convert string to UTF-32: ��
  values: CHECK( 15 >  15 )

@halx99 any idea why it fails?

@halx99
Copy link
Collaborator

halx99 commented Dec 1, 2025

#2909 duplicated PR ?

@halx99
Copy link
Collaborator

halx99 commented Dec 1, 2025

I don't think we should set AX_CORE_PROFILE to ON, due to it's only use when user want prepare upgrading to next major release of axmol

@crazyhappygame
Copy link
Contributor Author

#2909 duplicated PR ?

different branch

@crazyhappygame
Copy link
Contributor Author

I don't think we should set AX_CORE_PROFILE to ON, due to it's only use when user want prepare upgrading to next major release of axmol

the issie is that it does not work now ...

@crazyhappygame crazyhappygame changed the title AX_CORE_PROFILE on by default Update CMakeLists.txt AX_CORE_PROFILE fix usage of "ifndef AX_CORE_PROFILE" Dec 1, 2025
@halx99 halx99 added this to the 2.10.1 milestone Dec 1, 2025
@halx99 halx99 added the enhancement New feature or request label Dec 1, 2025
@halx99 halx99 merged commit 928934d into axmolengine:release/2.x Dec 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants