-
-
Notifications
You must be signed in to change notification settings - Fork 243
AX_CORE_PROFILE fix usage of "ifndef AX_CORE_PROFILE" #2910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
it looks like flakyh unit test. https://github.com/axmolengine/axmol/actions/runs/19804252495/job/56735998776?pr=2910 |
|
https://github.com/axmolengine/axmol/actions/runs/19804252495/job/56735998776?pr=2910 @halx99 any idea why it fails? |
|
#2909 duplicated PR ? |
|
I don't think we should set |
different branch |
the issie is that it does not work now ... |
Describe your changes
compilatin fails after enablaing ifndef AX_CORE_PROFILE
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR