From 643227235cbb24a95f721c2aab735799af921399 Mon Sep 17 00:00:00 2001 From: Cedric Paillet Date: Thu, 16 Feb 2023 09:33:41 +0100 Subject: [PATCH] Fix route response_model typing As the response is always a list (even if it's empty), we can remove the Optional. --- fastapi_crudrouter/core/_base.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fastapi_crudrouter/core/_base.py b/fastapi_crudrouter/core/_base.py index e45d33fe..504f670b 100644 --- a/fastapi_crudrouter/core/_base.py +++ b/fastapi_crudrouter/core/_base.py @@ -58,7 +58,7 @@ def __init__( "", self._get_all(), methods=["GET"], - response_model=Optional[List[self.schema]], # type: ignore + response_model=List[self.schema], # type: ignore summary="Get All", dependencies=get_all_route, ) @@ -78,7 +78,7 @@ def __init__( "", self._delete_all(), methods=["DELETE"], - response_model=Optional[List[self.schema]], # type: ignore + response_model=List[self.schema], # type: ignore summary="Delete All", dependencies=delete_all_route, )