Merge pull request #146 from joguSD/drop-none

Drop key from environment params if None

Author: joguSD

awsshell/wizard.py

@@ -1,6 +1,7 @@
 import sys
 import copy
 import json
+import logging
 import jmespath
 
 import botocore.session
@@ -15,6 +16,9 @@
 from prompt_toolkit.shortcuts import confirm
 
 
+LOG = logging.getLogger(__name__)
+
+
 def stage_error_handler(error, stages, confirm=confirm, prompt=select_prompt):
     managed_errors = (
         ClientError,
@@ -384,5 +388,10 @@ def resolve_parameters(self, keys):
         """
         resolved_dict = {}
         for key in keys:
-            resolved_dict[key] = self.retrieve(keys[key])
+            retrieved = self.retrieve(keys[key])
+            if retrieved is not None:
+                resolved_dict[key] = retrieved
+            else:
+                LOG.debug("Query failed (%s), dropped key: %s", keys[key], key)
+
         return resolved_dict

tests/unit/test_wizard.py

@@ -40,6 +40,12 @@ def test_resolve_parameters():
     assert resolved == {'a': 'Nice', 'b': 'v'}
 
 
+def test_resolve_parameters_drops_none(env):
+    keys = {'a': 'bad.query', 'b': 'env_var.epic'}
+    resolved = env.resolve_parameters(keys)
+    assert resolved == {'b': 'nice'}
+
+
 @pytest.fixture
 def loader(wizard_spec):
     session = mock.Mock()