change: ignore tags with 'aws:' prefix when creating an EndpointConfig based on an existing one (#1362)

Author: laurenyu

src/sagemaker/session.py

@@ -2312,11 +2312,16 @@ def create_endpoint_config_from_existing(
             existing_config_name (str): Name of the existing Amazon SageMaker endpoint
                 configuration.
             new_tags(List[dict[str, str]]): Optional. The list of tags to add to the endpoint
-                config.
+                config. If not specified, the tags of the existing endpoint configuration are used.
+                If any of the existing tags are reserved AWS ones (i.e. begin with "aws"),
+                they are not carried over to the new endpoint configuration.
             new_kms_key (str): The KMS key that is used to encrypt the data on the storage volume
-                attached to the instance hosting the endpoint.
+                attached to the instance hosting the endpoint (default: None). If not specified,
+                the KMS key of the existing endpoint configuration is used.
             new_data_capture_config_dict (dict): Specifies configuration related to Endpoint data
-                capture for use with Amazon SageMaker Model Monitoring. Default: None.
+                capture for use with Amazon SageMaker Model Monitoring (default: None).
+                If not specified, the data capture configuration of the existing
+                endpoint configuration is used.
 
         Returns:
             str: Name of the endpoint point configuration created.
@@ -2328,17 +2333,14 @@ def create_endpoint_config_from_existing(
             EndpointConfigName=existing_config_name
         )
 
-        existing_tags = self.sagemaker_client.list_tags(
-            ResourceArn=existing_endpoint_config_desc["EndpointConfigArn"]
-        )
-
-        request_tags = new_tags or existing_tags["Tags"]
-
         request = {
             "EndpointConfigName": new_config_name,
             "ProductionVariants": existing_endpoint_config_desc["ProductionVariants"],
         }
 
+        request_tags = new_tags or self.list_tags(
+            existing_endpoint_config_desc["EndpointConfigArn"]
+        )
         if request_tags:
             request["Tags"] = request_tags
 

tests/unit/test_session.py

@@ -1820,6 +1820,36 @@ def test_update_endpoint_non_existing_endpoint(sagemaker_session):
         sagemaker_session.update_endpoint("non-existing-endpoint", "non-existing-config")
 
 
+def test_create_endpoint_config_from_existing(sagemaker_session):
+    pvs = [sagemaker.production_variant("A", "ml.m4.xlarge")]
+    tags = [{"Key": "aws:cloudformation:stackname", "Value": "this-tag-should-be-ignored"}]
+    existing_endpoint_arn = "arn:aws:sagemaker:us-west-2:123412341234:endpoint-config/foo"
+    kms_key = "kms"
+    sagemaker_session.sagemaker_client.describe_endpoint_config.return_value = {
+        "Tags": tags,
+        "ProductionVariants": pvs,
+        "EndpointConfigArn": existing_endpoint_arn,
+        "KmsKeyId": kms_key,
+    }
+    sagemaker_session.sagemaker_client.list_tags.return_value = {"Tags": tags}
+
+    existing_endpoint_name = "foo"
+    new_endpoint_name = "new-foo"
+    sagemaker_session.create_endpoint_config_from_existing(
+        existing_endpoint_name, new_endpoint_name
+    )
+
+    sagemaker_session.sagemaker_client.describe_endpoint_config.assert_called_with(
+        EndpointConfigName=existing_endpoint_name
+    )
+    sagemaker_session.sagemaker_client.list_tags.assert_called_with(
+        ResourceArn=existing_endpoint_arn, MaxResults=50
+    )
+    sagemaker_session.sagemaker_client.create_endpoint_config.assert_called_with(
+        EndpointConfigName=new_endpoint_name, ProductionVariants=pvs, KmsKeyId=kms_key
+    )
+
+
 @patch("time.sleep")
 def test_wait_for_tuning_job(sleep, sagemaker_session):
     hyperparameter_tuning_job_desc = {"HyperParameterTuningJobStatus": "Completed"}