change: enable unidiomatic-typecheck pylint check (#921)

Author: knakad

.pylintrc

@@ -87,7 +87,6 @@ disable=
     attribute-defined-outside-init, # TODO: Fix scope
     protected-access, # TODO: Fix access
     abstract-method, # TODO: Fix abstract methods
-    unidiomatic-typecheck, # TODO: Fix typechecks
     wrong-import-order, # TODO: Fix import order
     no-else-return, # TODO: Remove unnecessary elses
     useless-object-inheritance, # TODO: Remove unnecessary imports

src/sagemaker/model.py

@@ -176,7 +176,7 @@ def _compilation_job_config(
         input_model_config = {
             "S3Uri": self.model_data,
             "DataInputConfig": input_shape
-            if type(input_shape) != dict
+            if not isinstance(input_shape, dict)
             else json.dumps(input_shape),
             "Framework": framework,
         }

src/sagemaker/vpc_utils.py

@@ -83,23 +83,23 @@ def sanitize(vpc_config):
     """
     if vpc_config is None:
         return vpc_config
-    elif type(vpc_config) is not dict:
+    elif not isinstance(vpc_config, dict):
         raise ValueError("vpc_config is not a dict: {}".format(vpc_config))
     elif not vpc_config:
         raise ValueError("vpc_config is empty")
 
     subnets = vpc_config.get(SUBNETS_KEY)
     if subnets is None:
         raise ValueError("vpc_config is missing key: {}".format(SUBNETS_KEY))
-    if type(subnets) is not list:
+    if not isinstance(subnets, list):
         raise ValueError("vpc_config value for {} is not a list: {}".format(SUBNETS_KEY, subnets))
     elif not subnets:
         raise ValueError("vpc_config value for {} is empty".format(SUBNETS_KEY))
 
     security_group_ids = vpc_config.get(SECURITY_GROUP_IDS_KEY)
     if security_group_ids is None:
         raise ValueError("vpc_config is missing key: {}".format(SECURITY_GROUP_IDS_KEY))
-    if type(security_group_ids) is not list:
+    if not isinstance(security_group_ids, list):
         raise ValueError(
             "vpc_config value for {} is not a list: {}".format(
                 SECURITY_GROUP_IDS_KEY, security_group_ids