Skip to content

Commit d06bb3f

Browse files
committed
Fix: Add NLS configuration to workbench.html
**Description** Add NLS configuration to workbench.html. This was missing from the display language fix
1 parent 57d2634 commit d06bb3f

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

patched-vscode/src/vs/code/browser/workbench/workbench.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
<!-- Workbench Configuration -->
2020
<meta id="vscode-workbench-web-configuration" data-settings="{{WORKBENCH_WEB_CONFIGURATION}}">
2121

22+
<!-- NLS Configuration -->
23+
<meta id="vscode-remote-nls-configuration" data-settings="{{NLS_CONFIGURATION}}">
24+
2225
<!-- Workbench Auth Session -->
2326
<meta id="vscode-workbench-auth-session" data-settings="{{WORKBENCH_AUTH_SESSION}}">
2427

patched-vscode/src/vs/server/node/remoteLanguagePacks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export function getNLSConfiguration(language: string, userDataPath: string): Pro
1717
let result = _cache.get(key);
1818
if (!result) {
1919
// The OS Locale on the remote side really doesn't matter, so we pass in the same language
20-
result = lp.getNLSConfiguration("dummy_commmit", userDataPath, metaData, language, language).then(value => {
20+
result = lp.getNLSConfiguration("dummy_commit", userDataPath, metaData, language, language).then(value => {
2121
if (InternalNLSConfiguration.is(value)) {
2222
value._languagePackSupport = true;
2323
}

patches/display-language.patch

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,17 @@ Index: sagemaker-code-editor/vscode/src/vs/code/browser/workbench/workbench.html
4646
===================================================================
4747
--- sagemaker-code-editor.orig/vscode/src/vs/code/browser/workbench/workbench.html
4848
+++ sagemaker-code-editor/vscode/src/vs/code/browser/workbench/workbench.html
49-
@@ -46,14 +46,26 @@
49+
@@ -19,6 +19,9 @@
50+
<!-- Workbench Configuration -->
51+
<meta id="vscode-workbench-web-configuration" data-settings="{{WORKBENCH_WEB_CONFIGURATION}}">
52+
53+
+ <!-- NLS Configuration -->
54+
+ <meta id="vscode-remote-nls-configuration" data-settings="{{NLS_CONFIGURATION}}">
55+
+
56+
<!-- Workbench Auth Session -->
57+
<meta id="vscode-workbench-auth-session" data-settings="{{WORKBENCH_AUTH_SESSION}}">
58+
59+
@@ -46,14 +49,26 @@
5060
// Normalize locale to lowercase because translationServiceUrl is case-sensitive.
5161
// ref: https://github.com/microsoft/vscode/issues/187795
5262
const locale = localStorage.getItem('vscode.nls.locale') || navigator.language.toLowerCase();
@@ -174,7 +184,7 @@ Index: sagemaker-code-editor/vscode/src/vs/server/node/remoteLanguagePacks.ts
174184
+ let result = _cache.get(key);
175185
+ if (!result) {
176186
+ // The OS Locale on the remote side really doesn't matter, so we pass in the same language
177-
+ result = lp.getNLSConfiguration("dummy_commmit", userDataPath, metaData, language, language).then(value => {
187+
+ result = lp.getNLSConfiguration("dummy_commit", userDataPath, metaData, language, language).then(value => {
178188
+ if (InternalNLSConfiguration.is(value)) {
179189
+ value._languagePackSupport = true;
180190
+ }

0 commit comments

Comments
 (0)