Skip to content

Commit 05ab0c4

Browse files
authored
Merge branch '1.8' into 1.8
Signed-off-by: Hudson Xing <77495133+harvenstar@users.noreply.github.com>
2 parents 4b58391 + 866a924 commit 05ab0c4

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

.github/workflows/release.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,11 @@ jobs:
6565
workflow: build.yml
6666
# Use the branch from the manual input.
6767
branch: ${{ github.event.inputs.source_branch }}
68+
6869
# Tell the action to look for artifacts created by a 'pull_request' event.
69-
event: push
70+
event: pull_request
7071
allow_forks: true
72+
7173
# We use a wildcard (*) because the artifact name from the build workflow
7274
# contains a dynamic commit SHA.
7375
name: npm-package
@@ -93,6 +95,7 @@ jobs:
9395
VERSION_NUM="${VERSION_TAG#v}"
9496
9597
# Create the new, clean filename for the release.
98+
9699
NEW_FILENAME="code-editor${VERSION_NUM}.tar.gz"
97100
98101
# Rename the file.
@@ -102,7 +105,9 @@ jobs:
102105
# Set the new filename as an output for the next step.
103106
echo "filename=./release-assets/$NEW_FILENAME" >> $GITHUB_OUTPUT
104107
108+
105109
# Step 6: Create the GitHub Release using the CORRECT commit SHA.
110+
106111
- name: Create GitHub Release
107112
uses: softprops/action-gh-release@v2
108113
with:
@@ -118,4 +123,5 @@ jobs:
118123
generate_release_notes: false
119124
# CRITICAL: Force the tag to be created on the commit we explicitly got in Step 2.
120125
# This overrides any incorrect metadata from the downloaded artifact.
121-
target_commitish: ${{ steps.get_sha.outputs.sha }}
126+
target_commitish: ${{ steps.get_sha.outputs.sha }}
127+

0 commit comments

Comments
 (0)