Commit 49b5d3a
authored
fix: use pypa/build to create Python sdists and wheels (#4850)
Using wheel directly generates `whl` files that aren't compliant with
https://packaging.python.org/en/latest/specifications/binary-distribution-format/#escaping-and-unicode
. Specifically, periods in the distribution name aren't converted to
underscores like setuptools would do. When uploading such a wheel to
PyPi, you get an email notification from them complaining about it and
warning that soon it would be denied.
However, running setup.py directly to do create a `bdist_wheel` now
produces a deprecation warning. The upstream advice is to use the
`pypa/build` module to wrap setuptools, so that's what I implemented
here. The Python target no longer depends on `wheel` directly, so I
removed it.1 parent 90915fa commit 49b5d3a
File tree
5 files changed
+13
-21
lines changed- packages/jsii-pacmak
- lib/targets
- python
- test/generated-code/__snapshots__
5 files changed
+13
-21
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
101 | 102 | | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | 103 | | |
112 | 104 | | |
113 | 105 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments