Adding createAnonymousCredentials

Author: davidh44

pom.xml

@@ -113,7 +113,7 @@
         <rxjava.version>2.2.21</rxjava.version>
         <commons-codec.verion>1.10</commons-codec.verion>
         <jmh.version>1.29</jmh.version>
-        <awscrt.version>0.19.0</awscrt.version>
+        <awscrt.version>0.19.1</awscrt.version>
 
         <!--Test dependencies -->
         <junit5.version>5.8.1</junit5.version>

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/Main.java

@@ -0,0 +1,42 @@
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License").
+ * You may not use this file except in compliance with the License.
+ * A copy of the License is located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ * or in the "license" file accompanying this file. This file is distributed
+ * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+package software.amazon.awssdk.transfer.s3;
+
+import java.net.URI;
+import java.nio.file.Paths;
+import software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider;
+import software.amazon.awssdk.regions.Region;
+
+// Reproduce Github customer's issue
+public class Main {
+    public static void main(String[] args) {
+
+        S3TransferManager transferManager =
+            S3TransferManager.builder()
+                             .s3ClientConfiguration(cfg -> cfg.credentialsProvider(AnonymousCredentialsProvider.create())
+                                .region(Region.EU_CENTRAL_1)
+            .targetThroughputInGbps(20.0)
+            .minimumPartSizeInBytes(10L * 1000)
+            .maxConcurrency(8)
+            .endpointOverride(URI.create("http://localhost:8080"))
+                        )
+                        .build();
+
+        transferManager.uploadFile(b -> b.source(Paths.get("file_path")));
+
+
+    }
+}

services/s3/pom.xml

@@ -143,5 +143,11 @@
             <artifactId>eventstream</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>com.amazonaws</groupId>
+            <artifactId>aws-java-sdk-s3</artifactId>
+            <version>1.11.404</version>
+            <scope>compile</scope>
+        </dependency>
     </dependencies>
 </project>

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/CrtCredentialsProviderAdapter.java

@@ -18,6 +18,7 @@
 
 import java.nio.charset.StandardCharsets;
 import software.amazon.awssdk.annotations.SdkInternalApi;
+import software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider;
 import software.amazon.awssdk.auth.credentials.AwsCredentials;
 import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
 import software.amazon.awssdk.auth.credentials.AwsSessionCredentials;
@@ -38,6 +39,11 @@ public CrtCredentialsProviderAdapter(AwsCredentialsProvider credentialsProvider)
         this.credentialsProvider = credentialsProvider;
         this.crtCredentials = new DelegateCredentialsProvider.DelegateCredentialsProviderBuilder()
             .withHandler(() -> {
+
+                if (credentialsProvider instanceof AnonymousCredentialsProvider) {
+                    return Credentials.createAnonymousCredentials();
+                }
+
                 AwsCredentials sdkCredentials = credentialsProvider.resolveCredentials();
                 byte[] accessKey = sdkCredentials.accessKeyId().getBytes(StandardCharsets.UTF_8);
                 byte[] secreteKey = sdkCredentials.secretAccessKey().getBytes(StandardCharsets.UTF_8);
@@ -47,10 +53,10 @@ public CrtCredentialsProviderAdapter(AwsCredentialsProvider credentialsProvider)
                     sessionTokens =
                         ((AwsSessionCredentials) sdkCredentials).sessionToken().getBytes(StandardCharsets.UTF_8);
                 }
-
                 return new Credentials(accessKey,
-                                       secreteKey,
-                                       sessionTokens);
+                                           secreteKey,
+                                           sessionTokens);
+
             }).build();
     }
 

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/crt/CrtCredentialProviderAdapterTest.java

@@ -22,6 +22,7 @@
 import java.nio.charset.StandardCharsets;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mockito;
+import software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider;
 import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
 import software.amazon.awssdk.auth.credentials.AwsCredentials;
 import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
@@ -91,4 +92,22 @@ public String secretAccessKey() {
         adapter.close();
         verify((SdkAutoCloseable) awsCredentialsProvider).close();
     }
+
+    @Test
+    public void crtCredentials_anonymousCredentialsProvider_shouldWork() {
+        AwsCredentialsProvider awsCredentialsProvider = AnonymousCredentialsProvider.create();
+
+        CrtCredentialsProviderAdapter adapter = new CrtCredentialsProviderAdapter(awsCredentialsProvider);
+        CredentialsProvider crtCredentialsProvider = adapter.crtCredentials();
+
+        Credentials crtCredentials = crtCredentialsProvider.getCredentials().join();
+
+        //assertThat(crtCredentials.getAccessKeyId()).isNull();
+        //assertThat(crtCredentials.getSecretAccessKey()).isNull();
+
+
+    }
+
+
+
 }