Skip to content

Commit 4d13d77

Browse files
authored
Fix flakey tests (#6399)
1 parent 17587f0 commit 4d13d77

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/multipart/S3MultipartClientGetObjectRetryBehaviorWiremockTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,9 @@ public void getObject_5xxErrorResponses_shouldNotReuseInitialErrorResponseWhenLo
162162
.isInstanceOf(CompletionException.class)
163163
.hasCauseInstanceOf(S3Exception.class)
164164
.hasMessageNotContaining(firstRequestId)
165-
.hasMessageNotContaining(String.valueOf(firstErrorStatusCode))
165+
.hasMessageNotContaining("Status Code: " + firstErrorStatusCode)
166166
.hasMessageContaining(secondRequestId)
167-
.hasMessageContaining(String.valueOf(secondErrorStatusCode));
167+
.hasMessageContaining("Status Code: " + secondErrorStatusCode);
168168

169169
verify(MAX_ATTEMPTS, getRequestedFor(urlEqualTo(String.format("/%s/%s?partNumber=1", BUCKET, KEY))));
170170
verify(0, getRequestedFor(urlEqualTo(String.format("/%s/%s?partNumber=2", BUCKET, KEY))));

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/multipart/S3MultipartClientGetObjectWiremockTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
import static com.github.tomakehurst.wiremock.client.WireMock.anyUrl;
2121
import static com.github.tomakehurst.wiremock.client.WireMock.get;
2222
import static com.github.tomakehurst.wiremock.client.WireMock.getRequestedFor;
23+
import static com.github.tomakehurst.wiremock.client.WireMock.lessThanOrExactly;
2324
import static com.github.tomakehurst.wiremock.client.WireMock.matching;
25+
import static com.github.tomakehurst.wiremock.client.WireMock.moreThan;
2426
import static com.github.tomakehurst.wiremock.client.WireMock.stubFor;
2527
import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
2628
import static com.github.tomakehurst.wiremock.client.WireMock.verify;
@@ -220,7 +222,8 @@ public void getObject_single500WithinMany200s_shouldNotRetryError(AsyncResponseT
220222
assertThat(e.getCause()).isInstanceOf(S3Exception.class);
221223
}
222224

223-
verify(1, getRequestedFor(urlEqualTo(String.format("/%s/%s?partNumber=1", BUCKET, errorKey))));
225+
verify(moreThan(0), getRequestedFor(urlEqualTo(String.format("/%s/%s?partNumber=1", BUCKET, errorKey))));
226+
verify(lessThanOrExactly(2), getRequestedFor(urlEqualTo(String.format("/%s/%s?partNumber=1", BUCKET, errorKey))));
224227
}
225228

226229
private static Stream<Arguments> partSizeAndTransformerParams() {

0 commit comments

Comments
 (0)