Skip to content

Commit 0a4f600

Browse files
authored
Revert "Add Business Metrics for Credential Providers (#6443)" (#6456)
This reverts commit 19720d9.
1 parent 19720d9 commit 0a4f600

File tree

50 files changed

+126
-1820
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+126
-1820
lines changed

.changes/next-release/feature-AWSSDKforJavav2-c2d8ec6.json

Lines changed: 0 additions & 6 deletions
This file was deleted.

core/auth/src/main/java/software/amazon/awssdk/auth/credentials/ChildProfileCredentialsProviderFactory.java

Lines changed: 1 addition & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -40,45 +40,5 @@ public interface ChildProfileCredentialsProviderFactory {
4040
* provider.
4141
* @return The credentials provider with permissions derived from the source credentials provider and profile.
4242
*/
43-
default AwsCredentialsProvider create(AwsCredentialsProvider sourceCredentialsProvider, Profile profile) {
44-
ChildProfileCredentialsRequest request = new ChildProfileCredentialsRequest(sourceCredentialsProvider, profile, null);
45-
return create(request);
46-
}
47-
48-
/**
49-
* Create a credentials provider for the provided profile, using the provided source credentials provider to authenticate
50-
* with AWS. In the case of STS, the returned credentials provider is for a role that has been assumed, and the provided
51-
* source credentials provider is the credentials that should be used to authenticate that the user is allowed to assume
52-
* that role.
53-
*
54-
* @param request The request containing all parameters needed to create the child credentials provider.
55-
* @return The credentials provider with permissions derived from the request parameters.
56-
*/
57-
AwsCredentialsProvider create(ChildProfileCredentialsRequest request);
58-
59-
final class ChildProfileCredentialsRequest {
60-
private final AwsCredentialsProvider sourceCredentialsProvider;
61-
private final Profile profile;
62-
private final String sourceFeatureId;
63-
64-
public ChildProfileCredentialsRequest(AwsCredentialsProvider sourceCredentialsProvider,
65-
Profile profile,
66-
String sourceFeatureId) {
67-
this.sourceCredentialsProvider = sourceCredentialsProvider;
68-
this.profile = profile;
69-
this.sourceFeatureId = sourceFeatureId;
70-
}
71-
72-
public AwsCredentialsProvider sourceCredentialsProvider() {
73-
return sourceCredentialsProvider;
74-
}
75-
76-
public Profile profile() {
77-
return profile;
78-
}
79-
80-
public String sourceFeatureId() {
81-
return sourceFeatureId;
82-
}
83-
}
43+
AwsCredentialsProvider create(AwsCredentialsProvider sourceCredentialsProvider, Profile profile);
8444
}

core/auth/src/main/java/software/amazon/awssdk/auth/credentials/ContainerCredentialsProvider.java

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import software.amazon.awssdk.auth.credentials.internal.HttpCredentialsLoader.LoadedCredentials;
4040
import software.amazon.awssdk.core.SdkSystemSetting;
4141
import software.amazon.awssdk.core.exception.SdkClientException;
42-
import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId;
4342
import software.amazon.awssdk.core.util.SdkUserAgent;
4443
import software.amazon.awssdk.regions.util.ResourcesEndpointProvider;
4544
import software.amazon.awssdk.regions.util.ResourcesEndpointRetryPolicy;
@@ -73,8 +72,7 @@
7372
public final class ContainerCredentialsProvider
7473
implements HttpCredentialsProvider,
7574
ToCopyableBuilder<ContainerCredentialsProvider.Builder, ContainerCredentialsProvider> {
76-
private static final String CLASS_NAME = "ContainerCredentialsProvider";
77-
private static final String PROVIDER_NAME = BusinessMetricFeatureId.CREDENTIALS_HTTP.value();
75+
private static final String PROVIDER_NAME = "ContainerCredentialsProvider";
7876
private static final Predicate<InetAddress> IS_LOOPBACK_ADDRESS = InetAddress::isLoopbackAddress;
7977
private static final Predicate<InetAddress> ALLOWED_HOSTS_RULES = IS_LOOPBACK_ADDRESS;
8078
private static final String HTTPS = "https";
@@ -92,8 +90,6 @@ public final class ContainerCredentialsProvider
9290
private final Boolean asyncCredentialUpdateEnabled;
9391

9492
private final String asyncThreadName;
95-
private final String sourceFeatureId;
96-
private final String providerName;
9793

9894
/**
9995
* @see #builder()
@@ -102,11 +98,7 @@ private ContainerCredentialsProvider(BuilderImpl builder) {
10298
this.endpoint = builder.endpoint;
10399
this.asyncCredentialUpdateEnabled = builder.asyncCredentialUpdateEnabled;
104100
this.asyncThreadName = builder.asyncThreadName;
105-
this.sourceFeatureId = builder.sourceFeatureId;
106-
this.providerName = StringUtils.isEmpty(builder.sourceFeatureId)
107-
? PROVIDER_NAME
108-
: builder.sourceFeatureId + "," + PROVIDER_NAME;
109-
this.httpCredentialsLoader = HttpCredentialsLoader.create(providerName());
101+
this.httpCredentialsLoader = HttpCredentialsLoader.create(PROVIDER_NAME);
110102

111103
if (Boolean.TRUE.equals(builder.asyncCredentialUpdateEnabled)) {
112104
Validate.paramNotBlank(builder.asyncThreadName, "asyncThreadName");
@@ -134,7 +126,7 @@ public static Builder builder() {
134126

135127
@Override
136128
public String toString() {
137-
return ToString.create(CLASS_NAME);
129+
return ToString.create(PROVIDER_NAME);
138130
}
139131

140132
private RefreshResult<AwsCredentials> refreshCredentials() {
@@ -168,10 +160,6 @@ private Instant prefetchTime(Instant expiration) {
168160
return ComparableUtils.minimum(oneHourFromNow, fifteenMinutesBeforeExpiration);
169161
}
170162

171-
private String providerName() {
172-
return this.providerName;
173-
}
174-
175163
@Override
176164
public AwsCredentials resolveCredentials() {
177165
return credentialsCache.get();
@@ -330,7 +318,6 @@ private static final class BuilderImpl implements Builder {
330318
private String endpoint;
331319
private Boolean asyncCredentialUpdateEnabled;
332320
private String asyncThreadName;
333-
private String sourceFeatureId;
334321

335322
private BuilderImpl() {
336323
asyncThreadName("container-credentials-provider");
@@ -340,7 +327,6 @@ private BuilderImpl(ContainerCredentialsProvider credentialsProvider) {
340327
this.endpoint = credentialsProvider.endpoint;
341328
this.asyncCredentialUpdateEnabled = credentialsProvider.asyncCredentialUpdateEnabled;
342329
this.asyncThreadName = credentialsProvider.asyncThreadName;
343-
this.sourceFeatureId = credentialsProvider.sourceFeatureId;
344330
}
345331

346332
@Override
@@ -373,16 +359,6 @@ public void setAsyncThreadName(String asyncThreadName) {
373359
asyncThreadName(asyncThreadName);
374360
}
375361

376-
@Override
377-
public Builder sourceFeatureId(String sourceFeatureId) {
378-
this.sourceFeatureId = sourceFeatureId;
379-
return this;
380-
}
381-
382-
public void setSourceFeatureId(String sourceFeatureId) {
383-
sourceFeatureId(sourceFeatureId);
384-
}
385-
386362
@Override
387363
public ContainerCredentialsProvider build() {
388364
return new ContainerCredentialsProvider(this);

core/auth/src/main/java/software/amazon/awssdk/auth/credentials/EnvironmentVariableCredentialsProvider.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import java.util.Optional;
1919
import software.amazon.awssdk.annotations.SdkPublicApi;
2020
import software.amazon.awssdk.auth.credentials.internal.SystemSettingsCredentialsProvider;
21-
import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId;
2221
import software.amazon.awssdk.utils.SystemSetting;
2322
import software.amazon.awssdk.utils.ToString;
2423

@@ -29,8 +28,7 @@
2928
@SdkPublicApi
3029
public final class EnvironmentVariableCredentialsProvider extends SystemSettingsCredentialsProvider {
3130

32-
private static final String CLASS_NAME = "EnvironmentVariableCredentialsProvider";
33-
private static final String PROVIDER_NAME = BusinessMetricFeatureId.CREDENTIALS_ENV_VARS.value();
31+
private static final String PROVIDER_NAME = "EnvironmentVariableCredentialsProvider";
3432

3533
private EnvironmentVariableCredentialsProvider() {
3634
}
@@ -54,6 +52,6 @@ protected String provider() {
5452

5553
@Override
5654
public String toString() {
57-
return ToString.create(CLASS_NAME);
55+
return ToString.create(PROVIDER_NAME);
5856
}
5957
}

core/auth/src/main/java/software/amazon/awssdk/auth/credentials/HttpCredentialsProvider.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
package software.amazon.awssdk.auth.credentials;
1717

1818
import software.amazon.awssdk.annotations.SdkPublicApi;
19-
import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId;
2019
import software.amazon.awssdk.utils.SdkAutoCloseable;
2120

2221
/**
@@ -49,16 +48,6 @@ interface Builder<TypeToBuildT extends HttpCredentialsProvider, BuilderT extends
4948
*/
5049
BuilderT endpoint(String endpoint);
5150

52-
/**
53-
* An optional string list of {@link BusinessMetricFeatureId} denoting previous credentials providers
54-
* that are chained with this one.
55-
* <p><b>Note:</b> This method is primarily intended for use by AWS SDK internal components
56-
* and should not be used directly by external users.</p>
57-
*/
58-
default BuilderT sourceFeatureId(String sourceFeatureId) {
59-
throw new UnsupportedOperationException();
60-
}
61-
6251
/**
6352
* Build the credentials provider based on the configuration on this builder.
6453
*/

core/auth/src/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,13 @@
3737
import software.amazon.awssdk.core.SdkSystemSetting;
3838
import software.amazon.awssdk.core.exception.SdkClientException;
3939
import software.amazon.awssdk.core.exception.SdkServiceException;
40-
import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId;
4140
import software.amazon.awssdk.profiles.ProfileFile;
4241
import software.amazon.awssdk.profiles.ProfileFileSupplier;
4342
import software.amazon.awssdk.profiles.ProfileFileSystemSetting;
4443
import software.amazon.awssdk.profiles.ProfileProperty;
4544
import software.amazon.awssdk.regions.util.HttpResourcesUtils;
4645
import software.amazon.awssdk.regions.util.ResourcesEndpointProvider;
4746
import software.amazon.awssdk.utils.Logger;
48-
import software.amazon.awssdk.utils.StringUtils;
4947
import software.amazon.awssdk.utils.ToString;
5048
import software.amazon.awssdk.utils.Validate;
5149
import software.amazon.awssdk.utils.builder.CopyableBuilder;
@@ -69,8 +67,7 @@ public final class InstanceProfileCredentialsProvider
6967
implements HttpCredentialsProvider,
7068
ToCopyableBuilder<InstanceProfileCredentialsProvider.Builder, InstanceProfileCredentialsProvider> {
7169
private static final Logger log = Logger.loggerFor(InstanceProfileCredentialsProvider.class);
72-
private static final String CLASS_NAME = "InstanceProfileCredentialsProvider";
73-
private static final String PROVIDER_NAME = BusinessMetricFeatureId.CREDENTIALS_IMDS.value();
70+
private static final String PROVIDER_NAME = "InstanceProfileCredentialsProvider";
7471
private static final String EC2_METADATA_TOKEN_HEADER = "x-aws-ec2-metadata-token";
7572
private static final String SECURITY_CREDENTIALS_RESOURCE = "/latest/meta-data/iam/security-credentials/";
7673
private static final String TOKEN_RESOURCE = "/latest/api/token";
@@ -93,9 +90,6 @@ public final class InstanceProfileCredentialsProvider
9390

9491
private final Duration staleTime;
9592

96-
private final String sourceFeatureId;
97-
private final String providerName;
98-
9993
/**
10094
* @see #builder()
10195
*/
@@ -108,12 +102,8 @@ private InstanceProfileCredentialsProvider(BuilderImpl builder) {
108102
.orElseGet(() -> ProfileFileSupplier.fixedProfileFile(ProfileFile.defaultProfileFile()));
109103
this.profileName = Optional.ofNullable(builder.profileName)
110104
.orElseGet(ProfileFileSystemSetting.AWS_PROFILE::getStringValueOrThrow);
111-
this.sourceFeatureId = builder.sourceFeatureId;
112-
this.providerName = StringUtils.isEmpty(builder.sourceFeatureId)
113-
? PROVIDER_NAME
114-
: builder.sourceFeatureId + "," + PROVIDER_NAME;
115105

116-
this.httpCredentialsLoader = HttpCredentialsLoader.create(providerName());
106+
this.httpCredentialsLoader = HttpCredentialsLoader.create(PROVIDER_NAME);
117107
this.configProvider =
118108
Ec2MetadataConfigProvider.builder()
119109
.profileFile(profileFile)
@@ -212,13 +202,9 @@ public void close() {
212202
credentialsCache.close();
213203
}
214204

215-
private String providerName() {
216-
return this.providerName;
217-
}
218-
219205
@Override
220206
public String toString() {
221-
return ToString.create(CLASS_NAME);
207+
return ToString.create(PROVIDER_NAME);
222208
}
223209

224210
private ResourcesEndpointProvider createEndpointProvider() {
@@ -386,7 +372,6 @@ static final class BuilderImpl implements Builder {
386372
private Supplier<ProfileFile> profileFile;
387373
private String profileName;
388374
private Duration staleTime;
389-
private String sourceFeatureId;
390375

391376
private BuilderImpl() {
392377
asyncThreadName("instance-profile-credentials-provider");
@@ -400,7 +385,6 @@ private BuilderImpl(InstanceProfileCredentialsProvider provider) {
400385
this.profileFile = provider.profileFile;
401386
this.profileName = provider.profileName;
402387
this.staleTime = provider.staleTime;
403-
this.sourceFeatureId = provider.sourceFeatureId;
404388
}
405389

406390
Builder clock(Clock clock) {
@@ -479,16 +463,6 @@ public void setStaleTime(Duration duration) {
479463
staleTime(duration);
480464
}
481465

482-
@Override
483-
public Builder sourceFeatureId(String sourceFeatureId) {
484-
this.sourceFeatureId = sourceFeatureId;
485-
return this;
486-
}
487-
488-
public void setSourceFeatureId(String sourceFeatureId) {
489-
sourceFeatureId(sourceFeatureId);
490-
}
491-
492466
@Override
493467
public InstanceProfileCredentialsProvider build() {
494468
return new InstanceProfileCredentialsProvider(this);

0 commit comments

Comments
 (0)