Fix serviceclientconfig build issues (#3864)

* Make serviceClientConfiguration()  default and throw unsupported operation exception

* Update client interface method

* Temporarily disable Poet Client tests

* remove unused imports

* Fix build issue

* Update codegen files and re-enable tests

* remove unnecessary method implementation from test client

Author: davidh44

codegen/src/main/java/software/amazon/awssdk/codegen/poet/client/AsyncClientInterface.java

@@ -16,7 +16,6 @@
 package software.amazon.awssdk.codegen.poet.client;
 
 import static java.util.stream.Collectors.toList;
-import static javax.lang.model.element.Modifier.ABSTRACT;
 import static javax.lang.model.element.Modifier.DEFAULT;
 import static javax.lang.model.element.Modifier.FINAL;
 import static javax.lang.model.element.Modifier.PUBLIC;
@@ -495,7 +494,8 @@ protected MethodSpec utilitiesMethod() {
     protected MethodSpec serviceClientConfigMethod() {
         return MethodSpec.methodBuilder("serviceClientConfiguration")
                          .addAnnotation(Override.class)
-                         .addModifiers(PUBLIC, ABSTRACT)
+                         .addModifiers(PUBLIC, DEFAULT)
+                         .addStatement("throw new $T()", UnsupportedOperationException.class)
                          .returns(new PoetExtension(model).getServiceConfigClass())
                          .build();
     }

codegen/src/main/java/software/amazon/awssdk/codegen/poet/client/SyncClientInterface.java

@@ -17,7 +17,6 @@
 
 import static java.util.stream.Collectors.toCollection;
 import static java.util.stream.Collectors.toList;
-import static javax.lang.model.element.Modifier.ABSTRACT;
 import static javax.lang.model.element.Modifier.DEFAULT;
 import static javax.lang.model.element.Modifier.FINAL;
 import static javax.lang.model.element.Modifier.PUBLIC;
@@ -534,7 +533,8 @@ protected MethodSpec utilitiesMethod() {
     protected MethodSpec serviceClientConfigMethod() {
         return MethodSpec.methodBuilder("serviceClientConfiguration")
                          .addAnnotation(Override.class)
-                         .addModifiers(PUBLIC, ABSTRACT)
+                         .addModifiers(PUBLIC, DEFAULT)
+                         .addStatement("throw new $T()", UnsupportedOperationException.class)
                          .returns(new PoetExtension(model).getServiceConfigClass())
                          .build();
     }

codegen/src/test/resources/software/amazon/awssdk/codegen/poet/client/test-json-async-client-interface.java

@@ -1743,7 +1743,9 @@ default CompletableFuture<StreamingOutputOperationResponse> streamingOutputOpera
     }
 
     @Override
-    JsonServiceClientConfiguration serviceClientConfiguration();
+    default JsonServiceClientConfiguration serviceClientConfiguration() {
+        throw new UnsupportedOperationException();
+    }
 
     /**
      * Create a {@link JsonAsyncClient} with the region loaded from the

codegen/src/test/resources/software/amazon/awssdk/codegen/poet/client/test-json-client-interface.java

@@ -1684,5 +1684,7 @@ static ServiceMetadata serviceMetadata() {
     }
 
     @Override
-    JsonServiceClientConfiguration serviceClientConfiguration();
+    default JsonServiceClientConfiguration serviceClientConfiguration() {
+        throw new UnsupportedOperationException();
+    }
 }

core/aws-core/src/main/java/software/amazon/awssdk/awscore/AwsClient.java

@@ -27,5 +27,7 @@
 public interface AwsClient extends SdkClient {
 
     @Override
-    AwsServiceClientConfiguration serviceClientConfiguration();
+    default AwsServiceClientConfiguration serviceClientConfiguration() {
+        throw new UnsupportedOperationException();
+    }
 }

test/sdk-benchmarks/src/main/java/software/amazon/awssdk/benchmark/enhanced/dynamodb/V2TestDynamoDbBaseClient.java

@@ -17,7 +17,6 @@
 
 import org.openjdk.jmh.infra.Blackhole;
 import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
-import software.amazon.awssdk.services.dynamodb.DynamoDbServiceClientConfiguration;
 
 abstract class V2TestDynamoDbBaseClient implements DynamoDbClient {
     protected final Blackhole bh;
@@ -34,10 +33,4 @@ public String serviceName() {
     @Override
     public void close() {
     }
-
-    @Override
-    public DynamoDbServiceClientConfiguration serviceClientConfiguration() {
-        return null;
-    }
-
 }