Fix SDK's API model sync utility to ignore models without sdkId (#1459)

jasdel · web-flow · commit f8d40e3f2986 · 2021-10-18T16:42:23.000-07:00
Updates the SDK's API model sync utility to ignore modeled service
shapes that do not have a `sdkId` or `aws.api#service` trait.
diff --git a/internal/repotools/cmd/syncAPIModels/main.go b/internal/repotools/cmd/syncAPIModels/main.go
@@ -115,8 +115,8 @@ func findSmithyModels(modelPath string) (map[string]SourceModel, error) {
 						name, path)
 				}
 				if shape.Traits.Service == nil {
-					return fmt.Errorf("smithy service doesn't have service trait %s, %s",
-						name, path)
+					// Ignore services that don't have an SDK id.
+					continue
 				}
 				if len(shape.Traits.Service.SDKID) == 0 {
 					return fmt.Errorf("smithy service doesn't have sdkId value %s, %s",

Original file line number	Diff line number	Diff line change
`@@ -115,8 +115,8 @@ func findSmithyModels(modelPath string) (map[string]SourceModel, error) {`
`115`	`115`	`name, path)`
`116`	`116`	`}`
`117`	`117`	`if shape.Traits.Service == nil {`
`118`		`- return fmt.Errorf("smithy service doesn't have service trait %s, %s",`
`119`		`- name, path)`
	`118`	`+ // Ignore services that don't have an SDK id.`
	`119`	`+ continue`
`120`	`120`	`}`
`121`	`121`	`if len(shape.Traits.Service.SDKID) == 0 {`
`122`	`122`	`return fmt.Errorf("smithy service doesn't have sdkId value %s, %s",`