Skip to content

Commit 900eb3e

Browse files
committed
Remove null Subjects from Lambda messages in conversion function
1 parent e06d354 commit 900eb3e

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

index.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ function convertLambdaMessage(message) {
7272
}
7373
}
7474

75+
if ('Subject' in message && message.Subject === null) {
76+
delete message.Subject;
77+
}
78+
7579
return message;
7680
}
7781

test/validator.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ var chai = require('chai'),
2525
Type: 'Notification',
2626
MessageId: '1',
2727
TopicArn: 'arn',
28+
Subject: null,
2829
Message: 'A Lambda message for you!',
2930
Timestamp: (new Date).toISOString(),
3031
SignatureVersion: '1',
@@ -66,6 +67,14 @@ describe('Message Validator', function () {
6667

6768
for (var j = 0; j < signableKeysForSubscription.length; j++) {
6869
if (signableKeysForSubscription[j] in validMessages[i]) {
70+
// skip signing null Subject fields to match Lambda behavior
71+
if (
72+
signableKeysForSubscription[j] === 'Subject' &&
73+
validMessages[i][signableKeysForSubscription[j]] === null
74+
) {
75+
continue;
76+
}
77+
6978
signer.update(signableKeysForSubscription[j] + "\n"
7079
+ validMessages[i][signableKeysForSubscription[j]] + "\n", 'utf8');
7180
}

0 commit comments

Comments
 (0)