delete dax original retryer

Author: shamaton

dax/internal/client/dax_retryer.go

@@ -24,63 +24,6 @@ import (
 	"github.com/aws/smithy-go"
 )
 
-////DaxRetryer implements EqualJitterBackoffStratergy for throttled requests
-//type DaxRetryer struct {
-//	BaseThrottleDelay time.Duration
-//	MaxBackoffDelay   time.Duration
-//}
-//
-//const (
-//	//DefaultBaseRetryDelay is base delay for throttled requests
-//	DefaultBaseRetryDelay = 70 * time.Millisecond
-//	//DefaultMaxBackoffDelay is max backoff delay for throttled requests
-//	DefaultMaxBackoffDelay = 20 * time.Second
-//)
-//
-//func (r *DaxRetryer) setRetryerDefaults() {
-//	if r.BaseThrottleDelay == 0 {
-//		r.BaseThrottleDelay = DefaultBaseRetryDelay
-//	}
-//	if r.MaxBackoffDelay == 0 {
-//		r.MaxBackoffDelay = DefaultMaxBackoffDelay
-//	}
-//}
-//
-////RetryRules returns the delay duration before retrying this request again
-//func (r DaxRetryer) RetryRules(req *request.Request) time.Duration {
-//	// ??? ProvisionedThroughputExceededException
-//	if req.IsErrorThrottle() {
-//		r.setRetryerDefaults()
-//		attempt := req.RetryCount
-//		minDelay := time.Duration(1<<uint64(attempt)) * r.BaseThrottleDelay
-//		if minDelay > r.MaxBackoffDelay {
-//			minDelay = r.MaxBackoffDelay
-//		}
-//		jitter := time.Duration(rand.Intn(int(minDelay)/2 + 1))
-//
-//		return minDelay/2 + jitter
-//	}
-//	return 0
-//}
-//
-////ShouldRetry returns true if the request should be retried.
-//func (r DaxRetryer) ShouldRetry(req *request.Request) bool {
-//	daxErr := req.Error.(daxError)
-//	codes := daxErr.CodeSequence()
-//	return len(codes) > 0 && (codes[0] == 1 || codes[0] == 2) || req.IsErrorThrottle() || isAuthCRequiredException(codes)
-//}
-//
-//// Error code [4.23.31.33] is for AuthenticationRequiredException
-//func isAuthCRequiredException(codes []int) bool {
-//	return len(codes) == 4 && codes[0] == 4 && codes[1] == 23 && codes[2] == 31 && codes[3] == 33
-//}
-//
-//// MaxRetries returns the number of maximum retries the service will use to make
-//// an individual API request.
-//func (r DaxRetryer) MaxRetries() int {
-//	return 0
-//}
-
 // IsErrorRetryable returns if the error is daxError
 // if code sequences correct any condition return a value other than unknown.
 func IsErrorRetryable(err error) aws.Ternary {

dax/internal/client/dax_retryer_test.go

@@ -77,84 +77,3 @@ func TestSleep(t *testing.T) {
 		t.Fatalf("err must be nil, but %T", err)
 	}
 }
-
-//func TestRetryThrottleCodes(t *testing.T) {
-//
-//	req := request.Request{}
-//	retryer := DaxRetryer{}
-//	attempt := 2
-//	req.RetryCount = attempt
-//	baseThrottleDelay := 70 * time.Millisecond
-//	//for throttling exception
-//	req.Error = newDaxRequestFailure([]int{0}, "ThrottlingException", "", "", 400)
-//
-//	if !retryer.ShouldRetry(&req) {
-//		t.Errorf("expected retry on throttling")
-//	}
-//	delay := retryer.RetryRules(&req)
-//	maxDelay := time.Duration(1<<uint64(attempt)) * baseThrottleDelay
-//	if delay > maxDelay {
-//		t.Errorf("delay more than expected, expected upto %d, got %d ", maxDelay, delay)
-//	}
-//	if delay <= 0 {
-//		t.Errorf("delay for throttled error should be greater than 0, got %d", delay)
-//	}
-//
-//	//for non throttling exception
-//	req.Error = newDaxRequestFailure([]int{0}, "AccessDeniedException", "", "", 400)
-//	if retryer.ShouldRetry(&req) || retryer.RetryRules(&req) != 0 {
-//		t.Errorf("no retry expected")
-//	}
-//}
-//
-//func TestRetryOnThrottlingException(t *testing.T) {
-//	cluster, _ := newTestCluster([]string{"127.0.0.1:8111"})
-//	cluster.update([]serviceEndpoint{{hostname: "localhost", port: 8121}})
-//	cc := ClusterDaxClient{config: DefaultConfig(), cluster: cluster}
-//
-//	flag := 0
-//	action := func(client DaxAPI, o RequestOptions) error {
-//		if flag == 0 {
-//			flag = 1
-//			return newDaxRequestFailure([]int{0}, "ThrottlingException", "", "", 400)
-//		}
-//		return nil
-//	}
-//
-//	opt := RequestOptions{
-//		MaxRetries: 2,
-//	}
-//
-//	err := cc.retry("op", action, opt)
-//
-//	if err != nil {
-//		t.Errorf("error %v", err)
-//	}
-//}
-//
-//func TestRetryOnAuthenticationRequiredException(t *testing.T) {
-//	cluster, _ := newTestCluster([]string{"127.0.0.1:8111"})
-//	cluster.update([]serviceEndpoint{{hostname: "localhost", port: 8121}})
-//	cc := ClusterDaxClient{config: DefaultConfig(), cluster: cluster}
-//
-//	flag := 0
-//	codes := []int{4, 23, 31, 33}
-//	action := func(client DaxAPI, o RequestOptions) error {
-//		if flag == 0 {
-//			flag = 1
-//			return newDaxRequestFailure(codes, "AuthenticationRequiredException", "", "", 400)
-//		}
-//		return nil
-//	}
-//
-//	opt := RequestOptions{
-//		MaxRetries: 2,
-//	}
-//
-//	err := cc.retry("op", action, opt)
-//
-//	if err != nil {
-//		t.Errorf("error %v", err)
-//	}
-//
-//}