update tests to pass

Author: kazmer97

lib/idp_common_pkg/idp_common/config/models.py

@@ -132,13 +132,6 @@ def parse_int(cls, v: Any) -> int:
             return int(v) if v else 0
         return int(v)
 
-    @model_validator(mode="after")
-    def model_validator(self) -> Self:
-        if not self.agentic.review_agent_model:
-            self.agentic.review_agent_model = self.model
-
-        return self
-
     @model_validator(mode="after")
     def set_default_review_agent_model(self) -> Self:
         """Set review_agent_model to extraction model if not specified."""

lib/idp_common_pkg/tests/unit/classification/test_classification_service.py

@@ -291,7 +291,8 @@ def test_classify_page_bedrock_success(
 
         # Verify calls
         mock_get_text.assert_called_once_with("s3://bucket/text.txt")
-        mock_prepare_image.assert_called_once_with("s3://bucket/image.jpg", None, None)
+        # ImageConfig defaults to 1200x1200 when not explicitly configured
+        mock_prepare_image.assert_called_once_with("s3://bucket/image.jpg", 1200, 1200)
         mock_prepare_bedrock_image.assert_called_once_with(b"image_data")
         mock_invoke.assert_called_once()
 

lib/idp_common_pkg/tests/unit/ocr/test_ocr_service.py

@@ -106,10 +106,10 @@ def test_init_textract_backend_default(self):
             assert service.max_workers == 20
             assert service.dpi is None  # Default is None
             assert service.enhanced_features is False
-            # Default image sizing
+            # Default image sizing (from ImageConfig defaults)
             assert service.resize_config == {
-                "target_width": 951,
-                "target_height": 1268,
+                "target_width": 1200,
+                "target_height": 1200,
             }
             assert service.preprocessing_config is None
 
@@ -198,10 +198,10 @@ def test_init_config_pattern_default_sizing(self):
         with patch("boto3.client"):
             service = OcrService(config=config)
 
-            # Verify defaults are applied
+            # Verify defaults are applied (from ImageConfig model defaults)
             assert service.resize_config == {
-                "target_width": 951,
-                "target_height": 1268,
+                "target_width": 1200,
+                "target_height": 1200,
             }
             assert service.dpi == 200
 
@@ -242,30 +242,34 @@ def test_init_config_pattern_empty_strings_apply_defaults(self):
         with patch("boto3.client"):
             service = OcrService(config=config)
 
-            # Verify defaults are applied (empty strings treated same as None)
+            # Verify OCR service defaults are applied (empty strings treated same as None)
+            # Note: Empty strings bypass Pydantic defaults, triggering OCR service defaults
             assert service.resize_config == {
                 "target_width": 951,
                 "target_height": 1268,
             }
             assert service.dpi == 150
 
     def test_init_config_pattern_partial_sizing(self):
-        """Test initialization with partial sizing configuration preserves existing behavior."""
+        """Test initialization with partial sizing configuration uses explicit width and default height."""
         config = {
             "ocr": {
                 "image": {
                     "dpi": 150,
                     "target_width": 800,
-                    # target_height missing - should disable defaults
+                    # target_height missing - Pydantic model provides default of 1200
                 }
             }
         }
 
         with patch("boto3.client"):
             service = OcrService(config=config)
 
-            # Verify partial config disables defaults
-            assert service.resize_config is None
+            # Verify explicit width is used with default height from ImageConfig model
+            assert service.resize_config == {
+                "target_width": 800,
+                "target_height": 1200,
+            }
             assert service.dpi == 150
 
     def test_init_config_pattern_invalid_sizing_fallback(self):